Skip to content

Conversation

@leesf
Copy link
Contributor

@leesf leesf commented Jan 1, 2019

What is the purpose of the change

Add back to top button for connectors overview docs.

Brief change log

Add back to top button for connectors overview docs.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@lamberken
Copy link
Member

lamberken commented Jan 1, 2019

hi, @leesf , happy new year. thanks for your pr. I think it's better to check all docs which need add back to top button.
for example, java_lambdas, ml, broadcast_state doc, and etc

@zentol zentol merged commit 84c2970 into apache:master Jan 1, 2019
@lamberken
Copy link
Member

lamberken commented Jan 1, 2019

happy new year 🎉

hi, @zentol. maybe it's better these java_lambdas, ml, broadcast_state doc need to add back to top button. do you think so? if so, it's no need to open a new pr

Best, lamber-ken

@leesf
Copy link
Contributor Author

leesf commented Jan 2, 2019

@lamber-ken happy new year, thanks for your reviewing. I could check all docs without Back to top button and update my another pr (#7360) since this pr is merged. cc @zentol

@lamberken
Copy link
Member

@lamber-ken happy new year, thanks for your reviewing. I could check all docs without Back to top button and update my another pr (#7360) since this pr is merged. cc @zentol

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants