Skip to content

[FLINK-12204][jdbc] Improve JDBCOutputFormat ClassCastException#8182

Closed
hequn8128 wants to merge 2 commits intoapache:masterfrom
hequn8128:classNotFound
Closed

[FLINK-12204][jdbc] Improve JDBCOutputFormat ClassCastException#8182
hequn8128 wants to merge 2 commits intoapache:masterfrom
hequn8128:classNotFound

Conversation

@hequn8128
Copy link
Copy Markdown
Contributor

@hequn8128 hequn8128 commented Apr 16, 2019

What is the purpose of the change

This pull request enriches ClassCastException for JDBCOutputFormat.

Note: I haven't added another wrapper for the exception. Instead, I just modify the ClassCastExceptoin’s error message and throw it. The stack would be more intuitive with less stack layer which I think is more user-friendly.

Brief change log

  • Enriches ClassCastException for JDBCOutputFormat with the index information.
  • Add tests to verify the enriched information.

Verifying this change

This change added tests and can be verified as follows:

  • Added testEnrichedClassCastException to test the enriched exception.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Apr 16, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ✅ 1. The [description] looks good.
  • ✅ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ✅ 4. The change fits into the overall [architecture].
  • ✅ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@fhueske
Copy link
Copy Markdown
Contributor

fhueske commented Apr 17, 2019

Thanks for the PR @hequn8128!
The changes are good, I'll merge it.

@flinkbot approve all

Thanks, Fabian

fhueske pushed a commit to fhueske/flink that referenced this pull request Apr 17, 2019
@asfgit asfgit closed this in 3b1c14f Apr 17, 2019
tianchen92 pushed a commit to tianchen92/flink that referenced this pull request May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants