[FLINK-12204][jdbc] Improve JDBCOutputFormat ClassCastException#8182
Closed
hequn8128 wants to merge 2 commits intoapache:masterfrom
Closed
[FLINK-12204][jdbc] Improve JDBCOutputFormat ClassCastException#8182hequn8128 wants to merge 2 commits intoapache:masterfrom
hequn8128 wants to merge 2 commits intoapache:masterfrom
Conversation
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
217f67b to
fb5014f
Compare
Contributor
|
Thanks for the PR @hequn8128! @flinkbot approve all Thanks, Fabian |
fhueske
pushed a commit
to fhueske/flink
that referenced
this pull request
Apr 17, 2019
tianchen92
pushed a commit
to tianchen92/flink
that referenced
this pull request
May 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request enriches
ClassCastExceptionforJDBCOutputFormat.Note: I haven't added another wrapper for the exception. Instead, I just modify the ClassCastExceptoin’s error message and throw it. The stack would be more intuitive with less stack layer which I think is more user-friendly.
Brief change log
ClassCastExceptionforJDBCOutputFormatwith the index information.Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation