Skip to content

[FLINK-12204][jdbc] Improve JDBCOutputFormat ClassCastException #8182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hequn8128 wants to merge 2 commits into from
Closed

[FLINK-12204][jdbc] Improve JDBCOutputFormat ClassCastException #8182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccc3fcd
[FLINK-12204][jdbc] Improve JDBCOutputFormat ClassCastException
hequn8128 Apr 16, 2019
fb5014f
rebase
hequn8128 Apr 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...nnectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,12 @@ public void writeRecord(Row row) throws IOException {
// case java.sql.Types.STRUC
}
} catch (ClassCastException e) {
throw new RuntimeException(
"Field index: " + index + ", field value: " + row.getField(index) + " " + e.getMessage(), e);
// enrich the exception with detailed information.
String errorMessage = String.format(
"%s, field index: %s, field value: %s.", e.getMessage(), index, row.getField(index));
ClassCastException enrichedException = new ClassCastException(errorMessage);
enrichedException.setStackTrace(e.getStackTrace());
throw enrichedException;
}
}
}
Expand Down
19 changes: 19 additions & 0 deletions ...k-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCFullTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,25 @@ public void testWithParallelism() throws Exception {
runTest(true);
}

@Test
public void testEnrichedClassCastException() throws Exception {
exception.expect(ClassCastException.class);
exception.expectMessage(
"java.lang.String cannot be cast to java.lang.Double, field index: 3, field value: 11.11.");

JDBCOutputFormat jdbcOutputFormat = JDBCOutputFormat.buildJDBCOutputFormat()
.setDrivername(JDBCTestBase.DRIVER_CLASS)
.setDBUrl(JDBCTestBase.DB_URL)
.setQuery("insert into newbooks (id, title, author, price, qty) values (?,?,?,?,?)")
.setSqlTypes(new int[]{Types.INTEGER, Types.VARCHAR, Types.VARCHAR, Types.DOUBLE, Types.INTEGER})
.finish();

jdbcOutputFormat.open(1, 1);
Row inputRow = Row.of(1001, "Java public for dummies", "Tan Ah Teck", "11.11", 11);
jdbcOutputFormat.writeRecord(inputRow);
jdbcOutputFormat.close();
}

private void runTest(boolean exploitParallelism) throws Exception {
ExecutionEnvironment environment = ExecutionEnvironment.getExecutionEnvironment();
JDBCInputFormatBuilder inputBuilder = JDBCInputFormat.buildJDBCInputFormat()
Expand Down
5 changes: 5 additions & 0 deletions ...k-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@

import org.junit.AfterClass;
import org.junit.BeforeClass;
import org.junit.Rule;
import org.junit.rules.ExpectedException;

import java.io.OutputStream;
import java.sql.Connection;
Expand All @@ -35,6 +37,9 @@
*/
public class JDBCTestBase {

@Rule
public ExpectedException exception = ExpectedException.none();

public static final String DRIVER_CLASS = "org.apache.derby.jdbc.EmbeddedDriver";
public static final String DB_URL = "jdbc:derby:memory:ebookshop";
public static final String INPUT_TABLE = "books";
Expand Down