Skip to content

Conversation

@NicoK
Copy link
Contributor

@NicoK NicoK commented Jun 27, 2019

What is the purpose of the change

Remove the (writable!) mount of a user's $HOME into the dockerized documentation build container in order to

  • make the builds independent from the host system (making them reproducible)
  • not have the commands in the container affect the host

Brief change log

  • remove mounting user $HOME

Verifying this change

I verified building the docs inside the new environment.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@sjwiesman
Copy link
Contributor

sjwiesman commented Jun 27, 2019

I noticed that the run script did not originally mount$HOME and then that was added by @patricklucas in #3751. Patrick can you just verify that removing this won't break something, I trust your docker knowledge over either of ours.

@NicoK
Copy link
Contributor Author

NicoK commented Jun 27, 2019

originally, it pointed to /home/${USER_NAME} which (on Linux) is basically the same - Patrick only made it work on MacOS as well

@sjwiesman
Copy link
Contributor

Gotcha, then +1

@NicoK
Copy link
Contributor Author

NicoK commented Jul 1, 2019

@sjwiesman Did you try building the docs with these changes? Just to be on the safe side and have someone else verify with a different OS at least (I'm on Linux)

@sjwiesman
Copy link
Contributor

Yes. I successfully built with these changes on a Mac

@StephanEwen
Copy link
Contributor

Looks good to me, merging this...

StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Jul 2, 2019
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Jul 2, 2019
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Jul 3, 2019
@asfgit asfgit closed this in 7a8333b Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants