-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-13017][docs] do not mount local $HOME into docker #8917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
|
I noticed that the run script did not originally mount |
|
originally, it pointed to |
|
Gotcha, then +1 |
|
@sjwiesman Did you try building the docs with these changes? Just to be on the safe side and have someone else verify with a different OS at least (I'm on Linux) |
|
Yes. I successfully built with these changes on a Mac |
|
Looks good to me, merging this... |
What is the purpose of the change
Remove the (writable!) mount of a user's $HOME into the dockerized documentation build container in order to
Brief change log
Verifying this change
I verified building the docs inside the new environment.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation