[bindings] map RpcError to NetworkException for Java parity#519
Merged
leekeiabstraction merged 1 commit intoMay 3, 2026
Merged
Conversation
Member
Author
charlesdong1991
approved these changes
May 1, 2026
Contributor
charlesdong1991
left a comment
charlesdong1991
left a comment
There was a problem hiding this comment.
Nice catch!!
Nit: Not sure about this Cargo.lock change, this code change doesn't have dependency changes, so shouldn't need?
Contributor
|
ohhhh, it's from that metrics PR!! My bad, forgot to sync the lock 🤦 thanks for the fix!! |
Member
Author
|
@charlesdong1991 Ty for the review, there is chore PR #518, we just need to merge and then I'll rebase 👍 |
fresh-borzoni
force-pushed
the
fix/rpc-error-as-network-exception
branch
2 times, most recently
from
c024773 to
cea2e22
Compare
fresh-borzoni
force-pushed
the
fix/rpc-error-as-network-exception
branch
from
cea2e22 to
cc6de86
Compare
Member
Author
|
rebased and updated elixir tests |
leekeiabstraction
approved these changes
May 3, 2026
Contributor
leekeiabstraction
left a comment
leekeiabstraction
left a comment
There was a problem hiding this comment.
TY for the PR. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #520
Transport failures (
Error::RpcError) were surfacing in Python / C++ / Elixir bindings asCLIENT_ERROR_CODE = -2, hiding their retriability.Java wraps the same kind of failure into
NetworkException(code 1, retriable). This PR does the same.