[helm] Support statefulset and service annotations#3687
Merged
Conversation
Member
Author
Contributor
|
Looks wonderful! Thanks for introducing this new level of flexibility. It will be probably renamed to @fresh-borzoni I don't see any update in the website documentation. Would you be willing to take care to add this in a separate PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3688
The metrics services already accept annotations, but the statefulsets and the main headless services don't. This adds coordinator.annotations / tablet.annotations for the statefulset metadata, and coordinator.service.annotations / tablet.service.annotations for the services, following the existing podAnnotations style.
Workload-level annotations are where tooling like Reloader (secret.reloader.stakater.com/reload) or Argo CD sync-waves hook in, without them you're stuck patching the chart output out-of-band.
Pure passthrough, no change to rendered output unless the values are set.