[rpc] Bound length-delimited field length against readable bytes#3756
Open
fresh-borzoni wants to merge 1 commit into
Open
[rpc] Bound length-delimited field length against readable bytes#3756fresh-borzoni wants to merge 1 commit into
fresh-borzoni wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3757
Generated Protobuf decoders allocate
new byte[len]for a length-delimited field before checking the declared length fits the bytes present, so a bogus length prefix results in a large allocation.Added
ProtoCodecUtils.readBytesLen, which rejects a length that is negative or larger than the buffer's readable bytes, and route the bytes, string, repeated-bytes and repeated-string decoders through it.