Skip to content

[server] Refine remote log manifest overlap handling - #3937

Open
wuchong wants to merge 1 commit into
apache:mainfrom
wuchong:codex/resolve-remote-log-todos
Open

[server] Refine remote log manifest overlap handling#3937
wuchong wants to merge 1 commit into
apache:mainfrom
wuchong:codex/resolve-remote-log-todos

Conversation

@wuchong

@wuchong wuchong commented Aug 10, 2026

Copy link
Copy Markdown
Member

Purpose

Follow up on the remote log overlap manifest handling introduced by #3822 and resolve the remaining implementation follow-ups.

Brief change log

  • Keep manifest start/end getters aligned with physical remote segment offsets.
  • Make immutable remote manifest snapshot reads lock-free.
  • Remove the obsolete incremental RemoteLogTablet mutation helper.
  • Clarify timestamp lookup behavior and update overlap regression coverage.

Tests

  • ./mvnw -pl fluss-common -DskipITs -Dfast -Dtest=RemoteLogManifestOverlapTest test (11 tests)
  • ./mvnw -pl fluss-server -am -DskipITs -Dfast -Dtest=RemoteLogTabletTest,RemoteLogTabletOverlapTest,DefaultRemoteLogStorageTest -Dsurefire.failIfNoSpecifiedTests=false test (22 tests)
  • Checkstyle, Spotless, and RAT checks passed in the reactor build.

API and Format

  • Remote manifest start/end getters now consistently report physical remote offsets.
  • No storage format changes.

Documentation

No user-facing documentation changes are required.

Generative AI disclosure

  • Yes — Codex (gpt-5.6-sol), reviewed by the human developer.

Use physical manifest offsets where required, simplify RemoteLogTablet snapshot reads, and remove the obsolete incremental mutation helper. Keep overlap and timestamp lookup behavior covered by updated tests.

Co-Authored-By: Codex <noreply@openai.com>
AI-Model: gpt-5.6-sol
AI-Contributed/Feature: 112/112
AI-Contributed/UT: 130/130
@wuchong
wuchong marked this pull request as ready for review August 10, 2026 16:12
@wuchong

wuchong commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

cc @gyang94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant