[rust] Reject empty or duplicate primary key columns - #4182
Conversation
fresh-borzoni
left a comment
fresh-borzoni
left a comment
There was a problem hiding this comment.
@beryllw Thank you, LGTM 👍 . While you're here, primary_key_named overwrites unconditionally, so calling it twice keeps the last one, whereas Java rejects with "Multiple primary keys are not supported." Shall we address it here as well?
naivedogger
left a comment
naivedogger
left a comment
There was a problem hiding this comment.
+1. One small follow-up from this earlier discussion: nested ROW field names are still not validated by fluss-rust. Blank or duplicate names are accepted, so Gateway validate_only returns 200 even though the server rejects the schema.
Could we track this as a follow-up fluss-rust fix as well? I’d be happy to help with it.
Agreed, let’s track it as a follow-up. Thanks! |
fresh-borzoni
left a comment
fresh-borzoni
left a comment
There was a problem hiding this comment.
@beryllw Thank you, left one additional comment, PTAL
fresh-borzoni
left a comment
fresh-borzoni
left a comment
There was a problem hiding this comment.
@beryllw Thank you, LGTM 👍
3 participants
Purpose
Linked issue: close #4180
Brief change log
Tests
API and Format
Documentation