-
Notifications
You must be signed in to change notification settings - Fork 462
[datalake/paimon] Introduce paimon encoding #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
59b809d to
2be5083
Compare
2be5083 to
b4a40ed
Compare
Contributor
Author
|
@wuchong The pr is to Introduce paimon encoding to Fluss. Could you please help review it |
wuchong
reviewed
Feb 27, 2025
fluss-common/src/main/java/com/alibaba/fluss/row/encode/paimon/PaimonBinaryRowWriter.java
Outdated
Show resolved
Hide resolved
fluss-common/src/main/java/com/alibaba/fluss/row/encode/paimon/PaimonBinaryRowWriter.java
Outdated
Show resolved
Hide resolved
fluss-common/src/test/java/com/alibaba/fluss/row/encode/paimon/PaimonKeyEncoderTest.java
Outdated
Show resolved
Hide resolved
fluss-common/src/main/java/com/alibaba/fluss/row/encode/paimon/PaimonBinaryRowWriter.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@wuchong Comments is addressed |
wuchong
approved these changes
Feb 28, 2025
Member
wuchong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
ZmmBigdata
pushed a commit
to ZmmBigdata/fluss
that referenced
this pull request
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #408
Introduce Paimon's encoding way to avoid include paimon bundle lib.
Introduce
PaimonBinaryRowWriterin Fluss which follows Fluss' encoding row way.Tests
PaimonKeyEncoderTest to verify the introduced paimon encoding way is same with paimon's own implementation.
FlinkUnionReadPrimaryKeyTableITCase#testPrimaryKeyTable alreay verify write Fluss row with paimon encoding&bucket way implemented in Fluss, we can still lookup the row correctly by Paimon ap
API and Format
Documentation