fix(java): row encoders custom codec accepts class supertype#2297
Closed
stevenschlansker wants to merge 1 commit intoapache:mainfrom
stevenschlansker:custom-codec-super
Closed
fix(java): row encoders custom codec accepts class supertype#2297stevenschlansker wants to merge 1 commit intoapache:mainfrom stevenschlansker:custom-codec-super
stevenschlansker wants to merge 1 commit intoapache:mainfrom
stevenschlansker:custom-codec-super
Conversation
this matters for e.g. `registerCustomCodec(Id.class, new CustomCodec<Id<T>, ...>);` since Id != Id<T> but Id is super of Id<T>
Contributor
Author
|
Actually, I'm not sure this is the right fix. Sorry for the noise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Encoders.registerCustomCodecnow allows class token to be supertype of Tthis matters for e.g.
registerCustomCodec(Id.class, new CustomCodec<Id<T>, ...>);sinceId.classis notId<T>butIdis super ofId<T>