Skip to content

fix(java): row encoders custom codec accepts class supertype #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stevenschlansker wants to merge 1 commit into from
Closed

fix(java): row encoders custom codec accepts class supertype #2297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions java/fory-format/src/main/java/org/apache/fory/format/encoder/Encoders.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ public void encode(MemoryBuffer buffer, T obj) {
* @param codec the codec to use
*/
public static <T> void registerCustomCodec(
Class<?> beanType, Class<T> type, CustomCodec<T, ?> codec) {
Class<?> beanType, Class<? super T> type, CustomCodec<T, ?> codec) {
TypeInference.registerCustomCodec(new CustomTypeRegistration(beanType, type), codec);
}

Expand All @@ -247,7 +247,7 @@ public static <T> void registerCustomCodec(
* @param type the type of field to handle
* @param codec the codec to use
*/
public static <T> void registerCustomCodec(Class<T> type, CustomCodec<T, ?> codec) {
public static <T> void registerCustomCodec(Class<? super T> type, CustomCodec<T, ?> codec) {
registerCustomCodec(Object.class, type, codec);
}

Expand Down
Loading