feat(java): capture and forward extra fields in compatible mode#3858
Closed
Tatenda-k wants to merge 1 commit into
Closed
feat(java): capture and forward extra fields in compatible mode#3858Tatenda-k wants to merge 1 commit into
Tatenda-k wants to merge 1 commit into
Conversation
Add ForyExtraFields sink, an opt-in mechanism for preserving unmatched remote fields during compatible-mode deserialization and replaying them on re-serialization. Covers both the interpreter and generated codepaths,
Tatenda-k
requested review from
PragmaTwice,
chaokunyang and
theweipeng
as code owners
July 15, 2026 20:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for preserving unknown fields during compatible serialization using
ForyExtraFields.A class opts in by declaring a
ForyExtraFieldssink. Fields present in the remote schema but not in the local schema are captured in the sink.Captured fields are replayed using the original remote
TypeDef, allowing them to be preserved across compatible serialization round trips involving different schemas.Replay serializers are cached by
(class, TypeDef), allowing a local class to replayForyExtraFieldscaptured from multiple remote schemas.Tests cover both enabled and disabled reference tracking, as well as both
codegen=trueandcodegen=false.Related issues
AI Contribution Checklist
yes, I included a completed AI Contribution Checklist in this PR description and the requiredAI Usage Disclosure.yes, my PR description includes the requiredai_reviewsummary and screenshot evidence of the final clean AI review results from both fresh reviewers on the current PR diff or current HEAD after the latest code changes.AI Contribution Checklist
Does this PR introduce any user-facing change?
Benchmark