GEODE-3421: Cleanup public API headers#145
Merged
Merged
Conversation
jake-at-work
approved these changes
Nov 9, 2017
| #include <geode/utils.hpp> | ||
| #include <geode/CacheableString.hpp> | ||
|
|
||
| #include "util/functional.hpp" |
Contributor
There was a problem hiding this comment.
While I like the rename, I think this one header should probably remain public. It provides the hash and equal_to for dereferenced shared_ptrobjects. It could be quite helpful. Though I suppose we can move it public later if people are asking for it.
Member
Author
There was a problem hiding this comment.
Unless you have strong opinion, I think I am going to stick with your second approach to keep it private until people are asking for it.
Contributor
|
What about Assert.hpp? Seems like it shouldn't be in the public API? |
Member
Author
|
Ah, I think you're right about Assert.hpp. I hadn't considered since it wasn't in the ticket. |
mmartell
pushed a commit
to mmartell/geode-native
that referenced
this pull request
Mar 6, 2018
GEODE-3421: Cleanup public API headers
mmartell
pushed a commit
to mmartell/geode-native
that referenced
this pull request
Mar 6, 2018
GEODE-3421: Cleanup public API headers
jake-at-work
pushed a commit
to jake-at-work/geode-native
that referenced
this pull request
Oct 6, 2018
GEODE-3421: Cleanup public API headers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the following out of the public API:
Testing: