GEODE-6641: Code impacts for support for two phase commit transactions#486
GEODE-6641: Code impacts for support for two phase commit transactions#486jake-at-work merged 3 commits intoapache:developfrom
Conversation
mivanac
force-pushed
the
feature/GEODE-6641
branch
from
8880fe1 to
0848ee6
Compare
jake-at-work
left a comment
jake-at-work
left a comment
There was a problem hiding this comment.
I’m concerned with the TX interface having both the 1 phase and 2 phase commit on it. Does it work that we can really do both from the same interface. Can I call begin/commit and begin/prepare/commit without issue interchangeably?
|
So, should I add some tests to verify there is no problems, or return old interface, and make it public? |
|
Yes you should make sure there are tests for this. I don’t think there is much in the way of tests around either of these two transaction types. |
mivanac
force-pushed
the
feature/GEODE-6641
branch
2 times, most recently
from
3ecf5bf to
75c8da8
Compare
mivanac
force-pushed
the
feature/GEODE-6641
branch
2 times, most recently
from
5e95a0f to
115b7e8
Compare
| @@ -0,0 +1,659 @@ | |||
| /* | |||
There was a problem hiding this comment.
Maybe you misunderstood my previous ask. This integration test should not be written in the old integration test framework. Please put in the new framework. See cppcache/integration/test for examples.
mivanac
force-pushed
the
feature/GEODE-6641
branch
3 times, most recently
from
c14aeb0 to
e8b50a1
Compare
mivanac
force-pushed
the
feature/GEODE-6641
branch
from
e8b50a1 to
17c922c
Compare
2 participants
Coding impacts, to add support of 2 phase commit to public interface.