Skip to content

GEODE-6641: Add ClientTransactionXATest to run#603

Merged
pdxcodemonkey merged 1 commit intoapache:developfrom
moleske:add-clienttransactionxatest-back
May 28, 2020
Merged

GEODE-6641: Add ClientTransactionXATest to run#603
pdxcodemonkey merged 1 commit intoapache:developfrom
moleske:add-clienttransactionxatest-back

Conversation

@moleske
Copy link
Copy Markdown
Member

@moleske moleske commented May 24, 2020

  • sort integration tests in CMakeLists

#486 Added this test, but since it was never added to CMakeLists it didn't run in the integration tests. I sorted the CMakeLists entries in hopes that it'll be easier to see missing tests. I only ran this test on Kubuntu 20.04 since my Windows build has been failing for awhile building with VS2019 (some sort of ACE building error). Also it was missing cluster.start() so the test wasn't initially working.

- sort integration tests in CMakeLists
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 28, 2020

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.35%. Comparing base (35b6d52) to head (f42e1f4).
⚠️ Report is 342 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #603      +/-   ##
===========================================
- Coverage    73.42%   73.35%   -0.07%     
===========================================
  Files          639      639              
  Lines        50926    50926              
===========================================
- Hits         37390    37356      -34     
- Misses       13536    13570      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pdxcodemonkey pdxcodemonkey merged commit a1f9244 into apache:develop May 28, 2020
@moleske moleske deleted the add-clienttransactionxatest-back branch May 28, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants