GEODE-6641: Add ClientTransactionXATest to run#603
Merged
pdxcodemonkey merged 1 commit intoapache:developfrom May 28, 2020
moleske:add-clienttransactionxatest-back
Merged
GEODE-6641: Add ClientTransactionXATest to run#603pdxcodemonkey merged 1 commit intoapache:developfrom moleske:add-clienttransactionxatest-back
pdxcodemonkey merged 1 commit intoapache:developfrom
moleske:add-clienttransactionxatest-back
Conversation
- sort integration tests in CMakeLists
mivanac
approved these changes
May 25, 2020
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #603 +/- ##
===========================================
- Coverage 73.42% 73.35% -0.07%
===========================================
Files 639 639
Lines 50926 50926
===========================================
- Hits 37390 37356 -34
- Misses 13536 13570 +34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#486 Added this test, but since it was never added to CMakeLists it didn't run in the integration tests. I sorted the CMakeLists entries in hopes that it'll be easier to see missing tests. I only ran this test on Kubuntu 20.04 since my Windows build has been failing for awhile building with VS2019 (some sort of ACE building error). Also it was missing
cluster.start()so the test wasn't initially working.