GEODE-9200: Clean up DisMess #793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdxcodemonkey
requested review from
echobravopapa,
jake-at-work,
mmartell and
mreddington
echobravopapa
approved these changes
Apr 27, 2021
echobravopapa
left a comment
echobravopapa
left a comment
There was a problem hiding this comment.
Thank you for cleaning up disMess.
mmartell
reviewed
Apr 28, 2021
mmartell
requested changes
Apr 28, 2021
Contributor
mmartell
left a comment
mmartell
left a comment
There was a problem hiding this comment.
Only issue is rename: sendNotConnectedMessageToAllRegions
jake-at-work
approved these changes
Apr 28, 2021
Contributor
jake-at-work
left a comment
jake-at-work
left a comment
There was a problem hiding this comment.
Approved, but some cosmetic things to cleanup before merging.
Quite a few odd formatting changes but otherwise looks good.
It would be nice to take advantage of some other changes in the areas you are touching. Like making use of some smart pointers if possible. Also if you're member variables name changes touches enough members to warrant a switch to the current naming convention that would be nice too.
| } else if (exceptionMsg.find( | ||
| "org.apache.geode.cache.TransactionDataRebalancedException") != | ||
| } else if (exceptionMsg.find("org.apache.geode.cache." | ||
| "TransactionDataRebalancedException") != |
Contributor
There was a problem hiding this comment.
This feels like an unintentional or at least less readable format change.
|
This pull request introduces 1 alert when merging 42f79a1 into 0f40b8d - view on LGTM.com new alerts:
|
jake-at-work
requested changes
Apr 28, 2021
jake-at-work
approved these changes
Apr 28, 2021
cppcache/src/CacheImpl.cpp
Outdated
| tcrHARegion->receiveNotification(regionMsg); | ||
| tcrHARegion->receiveNotification( | ||
| std::unique_ptr<TcrMessage>(new TcrMessageClientMarker( | ||
| new DataOutput(createDataOutput()), true))); |
Contributor
There was a problem hiding this comment.
Can we refactor away this constant true here?
mmartell
approved these changes
Apr 29, 2021
pdxcodemonkey
force-pushed
the
bugfix/GEODE-9200-all-endpoints-disconnected-leak
branch
3 times, most recently
from
093336f to
b3083be
Compare
- use dynamically allocated message for this, a la other messages - no longer leak an instance at shutdown, no more special case code for this message when deleting messages.
pdxcodemonkey
force-pushed
the
bugfix/GEODE-9200-all-endpoints-disconnected-leak
branch
from
b3083be to
503451c
Compare
pdxcodemonkey
deleted the
bugfix/GEODE-9200-all-endpoints-disconnected-leak
branch
gaussianrecurrence
pushed a commit
to gaussianrecurrence/geode-native
that referenced
this pull request
May 4, 2021
Remove static endpoint disconnected message - use dynamically allocated message for this, a la other messages - no longer leak an instance at shutdown, no more special case code for this message when deleting messages.
davebarnes97
pushed a commit
to davebarnes97/geode-native
that referenced
this pull request
Feb 9, 2022
Remove static endpoint disconnected message - use dynamically allocated message for this, a la other messages - no longer leak an instance at shutdown, no more special case code for this message when deleting messages.
davebarnes97
pushed a commit
to davebarnes97/geode-native
that referenced
this pull request
Feb 9, 2022
Remove static endpoint disconnected message - use dynamically allocated message for this, a la other messages - no longer leak an instance at shutdown, no more special case code for this message when deleting messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this message when deleting messages.