Skip to content

GEODE-8037 - Create BootstrappingService interface.#5030

Closed
yozaner1324 wants to merge 1 commit into
apache:developfrom
yozaner1324:GEODE-8037
Closed

GEODE-8037 - Create BootstrappingService interface.#5030
yozaner1324 wants to merge 1 commit into
apache:developfrom
yozaner1324:GEODE-8037

Conversation

@yozaner1324

Copy link
Copy Markdown
Contributor

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

@kohlmu-pivotal kohlmu-pivotal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moleske

moleske commented Apr 30, 2020

Copy link
Copy Markdown
Member

I looked at https://issues.apache.org/jira/projects/GEODE/issues/GEODE-8037 and the issue doesn't really explain why this is being added or what it will do (acceptance criteria or something of the like). I know there's the RFC but some details in the Geode Jira would be handy since I can't quite figure out what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants