Skip to content

Conversation

@kohlmu-pivotal
Copy link
Contributor

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

Patrick Johnson and others added 7 commits July 7, 2020 12:13
…les. (apache#5234)

JBossModuleServiceImpl can now register and load Modules using ModuleDescriptor. The ModuleDescriptor
can now contain source paths to be included in the module as code sources or
have dependencies on other modules.

The same functionality can now be represented/retrieved from the Manifest file
contained within the jar files.

Amended gradle scripts for geode-common-services and geode-common to now generate
manifest files containing "Class-Path" dependencies and project module dependencies
described in the "Dependent-Modules" attribute in the manifest file.
…ules' attirbutes to manifest file. (apache#5297)

GEODE-8043 - Create JBossModuleService and implement loadModule. (apache#5081)

GEODE-8294 - Integrate ModuleService into Geode.
	Integrated ModuleService into geode-membership.
	Integrate ModuleService into geode-cq.
	Integrate ModuleService into WAnServiceProvider
	Integrate ModuleService into ServerConnectionfactory.
	Integrate ModuleService into ListCollectingServiceLoader and InternalDistributedSystemMetricsService.
	Integrate ModuleService into HandshakeRequestOperationHandler and ValueSerializer
	Integrate ModuleService into CacheXml.
        Integrate ModuleService into CommandManager.
        Cleaned up library dependencies
        Moved BootstrappingService.java to geode-common-services
        Integrate ModuleService into tests and comments..

GEODE-8306 - Introduce GeodeEntityResolver2Interface.
@lgtm-com
Copy link

lgtm-com bot commented Jul 8, 2020

This pull request introduces 2 alerts and fixes 2 when merging cba6c8a into 9d7d467 - view on LGTM.com

new alerts:

  • 2 for Potential input resource leak

fixed alerts:

  • 2 for Unused variable, import, function or class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant