Skip to content

Conversation

@mivanac
Copy link
Contributor

@mivanac mivanac commented Mar 8, 2021

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

@lgtm-com
Copy link

lgtm-com bot commented Mar 8, 2021

This pull request fixes 1 alert when merging 2567ef4 into df0d3c0 - view on LGTM.com

fixed alerts:

  • 1 for Potential input resource leak

@mivanac mivanac force-pushed the GEODE-6150_X branch 3 times, most recently from 4b77909 to 1c35994 Compare March 10, 2021 08:39
@lgtm-com
Copy link

lgtm-com bot commented Mar 17, 2021

This pull request fixes 2 alerts when merging 2a19d55 into dfc1656 - view on LGTM.com

fixed alerts:

  • 2 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Mar 17, 2021

This pull request fixes 2 alerts when merging d817fcd into dfc1656 - view on LGTM.com

fixed alerts:

  • 2 for Dereferenced variable may be null

@mivanac mivanac marked this pull request as ready for review March 18, 2021 15:01
@mivanac mivanac closed this Mar 18, 2021
@mivanac
Copy link
Contributor Author

mivanac commented Mar 18, 2021

New PR created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant