Revert "GEODE-9495: Limit Thread Sleep In PubSubNativeRedisAcceptance…#6879
Merged
Conversation
ringles
requested review from
DonalEvans,
dschneider-pivotal,
jdeppe-pivotal,
kirklund,
nonbinaryprogrammer and
upthewaterspout
as code owners
September 17, 2021 22:14
DonalEvans
approved these changes
Sep 17, 2021
| // simplest way to wait for the sockets to be out of the TIME_WAIT state. The timeout of 240 sec | ||
| // was chosen because that is the default duration for TIME_WAIT on Windows. The timeouts for | ||
| // both mac and linux are significantly shorter. | ||
| Thread.sleep(240000); |
Contributor
There was a problem hiding this comment.
How about configuring the host machines to cycle out of TIME_WAT faster and/or increasing the ephemeral port range?
There was a problem hiding this comment.
I think the plan is to reintroduce the changes being reverted in this PR shortly, this commit has broken our acceptance tests so we're just removing it from develop to unblock the pipeline.
dschneider-pivotal
approved these changes
Sep 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit ed902f6. Not
working reliably in the pipeline.