GEODE-9829: Add SINTER command to Redis supported commands.#7236
Merged
ringles merged 14 commits intoapache:developfrom Jan 13, 2022
Merged
GEODE-9829: Add SINTER command to Redis supported commands.#7236ringles merged 14 commits intoapache:developfrom
ringles merged 14 commits intoapache:developfrom
Conversation
BalaKaza
requested review from
DonalEvans,
dschneider-pivotal,
jdeppe-pivotal,
kirklund,
nonbinaryprogrammer,
ringles and
upthewaterspout
as code owners
|
This pull request introduces 1 alert when merging d3877e9 into 5e9c775 - view on LGTM.com new alerts:
|
jdeppe-pivotal
requested changes
Jan 4, 2022
...ava/org/apache/geode/redis/internal/commands/executor/set/AbstractSInterIntegrationTest.java
Outdated
Show resolved
Hide resolved
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSet.java
Outdated
Show resolved
Hide resolved
dschneider-pivotal
requested changes
Jan 4, 2022
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSet.java
Outdated
Show resolved
Hide resolved
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSet.java
Outdated
Show resolved
Hide resolved
DonalEvans
requested changes
Jan 5, 2022
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSet.java
Outdated
Show resolved
Hide resolved
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSet.java
Outdated
Show resolved
Hide resolved
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSet.java
Show resolved
Hide resolved
...ava/org/apache/geode/redis/internal/commands/executor/set/AbstractSInterIntegrationTest.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/geode/redis/internal/commands/executor/set/AbstractSInterIntegrationTest.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/geode/redis/internal/commands/executor/set/AbstractSInterIntegrationTest.java
Outdated
Show resolved
Hide resolved
DonalEvans
requested changes
Jan 5, 2022
...ava/org/apache/geode/redis/internal/commands/executor/set/AbstractSInterIntegrationTest.java
Outdated
Show resolved
Hide resolved
DonalEvans
approved these changes
Jan 5, 2022
nonbinaryprogrammer
approved these changes
Jan 7, 2022
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSet.java
Show resolved
Hide resolved
nonbinaryprogrammer
requested review from
dschneider-pivotal and
jdeppe-pivotal
jdeppe-pivotal
approved these changes
Jan 7, 2022
dschneider-pivotal
requested changes
Jan 10, 2022
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSet.java
Outdated
Show resolved
Hide resolved
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSet.java
Outdated
Show resolved
Hide resolved
BalaKaza
requested review from
Bill,
agingade,
boglesby,
echobravopapa,
kamilla1201 and
nabarunnag
as code owners
SINTER command is implemented and integration tests and added to test this command. Co-authored-by: Bala Kaza Venkata <bkazavenkata@vmware.com> Co-authored-by: Steve Sienkowski <ssienkowski@vmware.com> Co-authored-by: Kristen Oduca <koduca@vmware.com>
Resolve PR comments. Authored-by: Bala Kaza Venkata <bkazavenkata@vmware.com>
Rename test constants. Authored-by: Bala Kaza Venkata <bkazavenkata@vmware.com>
added 5 commits
January 11, 2022 10:43
Optimize looping on the sinter command. Authored-by: Bala Kaza Venkata <bkazavenkata@vmware.com>
This reverts commit 0294e34.
Refactor sinter method for readability. Authored-by: Bala Kaza Venkata <bkazavenkata@vmware.com>
Rename test constants. Authored-by: Bala Kaza Venkata <bkazavenkata@vmware.com>
Refactor sinter method for readability. Authored-by: Bala Kaza Venkata <bkazavenkata@vmware.com>
Kris-10-0
force-pushed
the
feature/GEODE-9829
branch
from
073bae7 to
d9ed942
Compare
Update SINTER method to get the accurate smallest set. Authored-by: Bala Kaza Venkata <bkazavenkata@vmware.com>
DonalEvans
requested changes
Jan 11, 2022
...ava/org/apache/geode/redis/internal/commands/executor/set/AbstractSInterIntegrationTest.java
Outdated
Show resolved
Hide resolved
Use tag1 instead of user1 in the redis set test. Authored-by: Bala Kaza Venkata <bkazavenkata@vmware.com>
DonalEvans
approved these changes
Jan 12, 2022
dschneider-pivotal
requested changes
Jan 12, 2022
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSet.java
Outdated
Show resolved
Hide resolved
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSet.java
Outdated
Show resolved
Hide resolved
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSet.java
Outdated
Show resolved
Hide resolved
Update the equals case to compare smallest set to not take longer. Authored-by: Bala Kaza Venkata <bkazavenkata@vmware.com>
dschneider-pivotal
approved these changes
Jan 12, 2022
...redis/src/main/java/org/apache/geode/redis/internal/commands/executor/set/SetOpExecutor.java
Show resolved
Hide resolved
Update grgit package to 4.1.1 to fix gradle build failure. Authored-by: Bala Kaza Venkata <bkazavenkata@vmware.com>
onichols-pivotal
approved these changes
Jan 12, 2022
DonalEvans
reviewed
Jan 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SINTER command is implemented and integration tests and added to test this
command.
Co-authored-by: Bala Kaza Venkata bkazavenkata@vmware.com
Co-authored-by: Steve Sienkowski ssienkowski@vmware.com
Co-authored-by: Kristen Oduca koduca@vmware.com
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?