[WIP][document] Update logo and trademark info - #1110
Merged
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
FelixYBW
previously approved these changes
Mar 13, 2023
Contributor
|
@weiting-chen can you check with other contributor if they would like to put their icon there? |
Contributor
Author
|
Ok, will check with them and update later. |
Contributor
Author
|
@FelixYBW Add meituan and bigo logo. Need to get the approval again. |
weiting-chen
force-pushed
the
update_company_logo
branch
from
March 20, 2023 11:16
99b7d0c to
dbabed2
Compare
FelixYBW
previously approved these changes
Mar 20, 2023
weiting-chen
force-pushed
the
update_company_logo
branch
from
March 21, 2023 01:01
13d89e8 to
5f57885
Compare
FelixYBW
previously approved these changes
Mar 21, 2023
Contributor
|
@zzcclp Can you check? |
align size and position
nielspardon
added a commit
to nielspardon/gluten
that referenced
this pull request
Jul 29, 2026
…ypes Substrait 0.98 removed the fixed-resolution temporal types Timestamp/Time/ TimestampTZ (apache#994) and the deprecated user_defined_type_reference (apache#1095) from the Type.kind oneof, replacing the temporals with explicit-precision variants PrecisionTimestamp/PrecisionTime/PrecisionTimestampTZ (apache#1110). Migrate Gluten's vendored type.proto and all producers/consumers in lockstep: - type.proto: reserve 14/17/29/31; add PrecisionTimestamp=33, PrecisionTimestampTZ=34, PrecisionTime=36 (matching 0.98 field numbers). - Producers emit precision=6: Spark TimestampType -> PrecisionTimestampTZ, TimestampNTZType -> PrecisionTimestamp (both microsecond), and Velox TIMESTAMP / CH DateTime64(6) likewise. Updated TimestampTypeNode, TimestampNTZTypeNode, VeloxToSubstraitType, and the ClickHouse SerializedPlanBuilder. - Consumers read the new kinds: ConverterUtils.parseFromSubstraitType (PRECISION_TIMESTAMP -> TimestampNTZType, PRECISION_TIMESTAMP_TZ -> TimestampType), Velox SubstraitParser (kPrecisionTimestamp/kPrecisionTimestampTz), and CH TypeParser (has_precision_timestamp_tz). Type.Nothing (Gluten's forked bottom type for Spark NullType) collided with official precision_timestamp at field 33. It is relocated to field 40 and otherwise kept unchanged; dropping the fork (mapping NullType to a typed null) has cross-backend semantics and is deferred to a dedicated follow-up. This keeps the change a pure temporal rename plus a mechanical field relocation with no semantic change. The Literal temporal fields (algebra.proto) are likewise unchanged and migrate in a later increment. Added ConverterUtilsSuite covering the temporal round-trip (getTypeNode -> toProtobuf -> parseFromSubstraitType) and asserting precision=6 for both types. Validated locally: proto (protoc), gluten-substrait JVM build + the new suite, and the Velox native build (libgluten/libvelox). The ClickHouse native parsers are covered by CI (a local libch build requires a Linux/Docker toolchain). Part of apache#12597. Depends on apache#12642 (AdvancedExtension.optimization repeated). 🤖 Generated with AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add Intel and Kyligence logo and trademark information.
How was this patch tested?
N/A, README Change Only