Skip to content

[WIP][document] Update logo and trademark info - #1110

Merged
weiting-chen merged 6 commits into
apache:mainfrom
weiting-chen:update_company_logo
Mar 21, 2023
Merged

[WIP][document] Update logo and trademark info#1110
weiting-chen merged 6 commits into
apache:mainfrom
weiting-chen:update_company_logo

Conversation

@weiting-chen

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Add Intel and Kyligence logo and trademark information.

How was this patch tested?

N/A, README Change Only

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[Gluten-${ISSUES_ID}] ${detailed message}

See also:

@weiting-chen
weiting-chen requested a review from FelixYBW March 13, 2023 06:48
FelixYBW
FelixYBW previously approved these changes Mar 13, 2023
@FelixYBW

Copy link
Copy Markdown
Contributor

@weiting-chen can you check with other contributor if they would like to put their icon there?

@weiting-chen

Copy link
Copy Markdown
Contributor Author

Ok, will check with them and update later.

@weiting-chen

Copy link
Copy Markdown
Contributor Author

@FelixYBW Add meituan and bigo logo. Need to get the approval again.

FelixYBW
FelixYBW previously approved these changes Mar 20, 2023
FelixYBW
FelixYBW previously approved these changes Mar 21, 2023
@FelixYBW

Copy link
Copy Markdown
Contributor

@zzcclp Can you check?

align size and position

@zzcclp zzcclp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhztheplayer zhztheplayer changed the title [WIP][document]Update logo and trademark info. [WIP][document] Update logo and trademark info Mar 21, 2023
@weiting-chen
weiting-chen merged commit 8c24445 into apache:main Mar 21, 2023
nielspardon added a commit to nielspardon/gluten that referenced this pull request Jul 29, 2026
…ypes

Substrait 0.98 removed the fixed-resolution temporal types Timestamp/Time/
TimestampTZ (apache#994) and the deprecated user_defined_type_reference (apache#1095) from
the Type.kind oneof, replacing the temporals with explicit-precision variants
PrecisionTimestamp/PrecisionTime/PrecisionTimestampTZ (apache#1110). Migrate Gluten's
vendored type.proto and all producers/consumers in lockstep:

- type.proto: reserve 14/17/29/31; add PrecisionTimestamp=33,
  PrecisionTimestampTZ=34, PrecisionTime=36 (matching 0.98 field numbers).
- Producers emit precision=6: Spark TimestampType -> PrecisionTimestampTZ,
  TimestampNTZType -> PrecisionTimestamp (both microsecond), and Velox TIMESTAMP
  / CH DateTime64(6) likewise. Updated TimestampTypeNode, TimestampNTZTypeNode,
  VeloxToSubstraitType, and the ClickHouse SerializedPlanBuilder.
- Consumers read the new kinds: ConverterUtils.parseFromSubstraitType
  (PRECISION_TIMESTAMP -> TimestampNTZType, PRECISION_TIMESTAMP_TZ ->
  TimestampType), Velox SubstraitParser (kPrecisionTimestamp/kPrecisionTimestampTz),
  and CH TypeParser (has_precision_timestamp_tz).

Type.Nothing (Gluten's forked bottom type for Spark NullType) collided with
official precision_timestamp at field 33. It is relocated to field 40 and
otherwise kept unchanged; dropping the fork (mapping NullType to a typed null)
has cross-backend semantics and is deferred to a dedicated follow-up. This keeps
the change a pure temporal rename plus a mechanical field relocation with no
semantic change. The Literal temporal fields (algebra.proto) are likewise
unchanged and migrate in a later increment.

Added ConverterUtilsSuite covering the temporal round-trip (getTypeNode ->
toProtobuf -> parseFromSubstraitType) and asserting precision=6 for both types.

Validated locally: proto (protoc), gluten-substrait JVM build + the new suite,
and the Velox native build (libgluten/libvelox). The ClickHouse native parsers
are covered by CI (a local libch build requires a Linux/Docker toolchain). Part
of apache#12597.

Depends on apache#12642 (AdvancedExtension.optimization repeated).

🤖 Generated with AI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants