[VL][Delta] Add persistent DV DELETE correctness path#12216
Draft
malinjawi wants to merge 11 commits into
Draft
Conversation
Keep Delta DV DML row-index target scans on Spark unless native DML row-index scanning and native write are explicitly enabled. Preserve the Spark Project/Filter subtree above the fallback scan and add Delta 3.3/4.0 plan-shape coverage for metadata row-index on and off. Validation: JAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home ./build/mvn test-compile -pl backends-velox -am -Pjava-17,spark-3.5,backends-velox,hadoop-3.3,spark-ut,delta -DskipTests Validation: JAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home ./build/mvn test-compile -pl backends-velox -am -Pjava-17,spark-4.0,scala-2.13,backends-velox,hadoop-3.3,spark-ut,delta -DskipTests Validation: git diff --cached --check
|
Run Gluten Clickhouse CI on x86 |
malinjawi
force-pushed
the
split/delta-dv-delete-correctness
branch
from
c43e4fa to
bbb971f
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
Route Delta DELETE commands with persistent deletion vectors through the Gluten-specific command while leaving metadata-only, full-table, and non-DV cases on the existing Delta path. Add Delta 3.3 and Delta 4.0 coverage for persistent DV DELETE routing and repeated deletion-vector updates. Validation: git diff --cached --check; mvn test-compile -pl backends-velox -am -Pjava-17,spark-3.5,backends-velox,hadoop-3.3,spark-ut,delta -DskipTests; mvn test-compile -pl backends-velox -am -Pjava-17,spark-4.0,scala-2.13,backends-velox,hadoop-3.3,spark-ut,delta -DskipTests.
malinjawi
force-pushed
the
split/delta-dv-delete-correctness
branch
from
e705eb8 to
1ba990c
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
This is the next stacked Delta DV MoR slice after #12215. It adds the minimal persistent-DV DELETE correctness path for Velox Delta native execution while keeping Delta OSS semantics for action generation, stats, and transaction behavior.
Stack order:
This PR should remain draft until the earlier scan-safety PR has reviewer confidence and this branch has native CI signal.
Scope
GlutenDeleteCommandfor persistent-DV row-condition DELETEs.Intentionally deferred
Validation
Local validation after rebasing onto
origin/split/delta-dv-dml-scan-safetyatf3135560c7a3d7a0dfedc1f64267c9a529e7a970:git diff --check origin/split/delta-dv-dml-scan-safety...HEADenv JAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home PATH=/opt/homebrew/opt/openjdk@17/bin:$PATH ./build/mvn -q test-compile -pl gluten-delta -am -Pjava-17,spark-3.4,backends-velox,hadoop-3.3,spark-ut,delta -DskipTestsafter restacking onto the Spark 3.3/3.4 compatibility fix in [VL][Delta] Guard DV DML row-index scans #12215env JAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home PATH=/opt/homebrew/opt/openjdk@17/bin:$PATH ./build/mvn -q test-compile -pl backends-velox -am -Pjava-17,spark-3.5,backends-velox,hadoop-3.3,spark-ut,delta -DskipTestsenv JAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home PATH=/opt/homebrew/opt/openjdk@17/bin:$PATH ./build/mvn -q test-compile -pl backends-velox -am -Pjava-17,spark-4.0,scala-2.13,backends-velox,hadoop-3.3,spark-ut,delta -DskipTestsFocused local ScalaTest execution was attempted for
DeleteSQLWithDeletionVectorsSuitebut this Mac checkout cannot start the Velox backend becausedarwin/aarch64/libgluten.dylibis not available. The run reached Spark startup and aborted before executing tests withFileNotFoundException: darwin/aarch64/libgluten.dylib. Treat native CI as the runtime correctness gate for this draft.