[VL] Update Velox build to look for Thrift in ${CMAKE_PREFIX_PATH}/lib#12422
Closed
kevinwilfong wants to merge 1 commit into
Closed
[VL] Update Velox build to look for Thrift in ${CMAKE_PREFIX_PATH}/lib#12422kevinwilfong wants to merge 1 commit into
kevinwilfong wants to merge 1 commit into
Conversation
Member
|
@kevinwilfong, thanks for the PR. Could you check the following new commit to see whether it has already fixed this issue? ce411ad |
Collaborator
Author
|
That looks like it fixes it, I'll close this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
At least on Mac, Velox installs its dependencies in a directory local to the checkout, with Gluten this is typically incubator-gluten/ep/build-velox/build/velox_ep/deps-install. One of these dependencies is fbthrift.
Currently the CMakeLists.txt file in cpp/velox is hard coded to look for Thrift in /usr/local/lib, which is inconsistent and results in an error building Gluten.
The fix is to update the CMakeLists.txt file to look for Thrift in the directory Velox installs its dependencies ${CMAKE_PREFIX_PATH} and if it can't find it there fall back to /usr/local/lib to preserve the existing behavior.
How was this patch tested?
Ran
./dev/builddeps-veloxbe.sh build_gluten_cppon a Mac without Thrift installed in /usr/local/lib and verified it could find Thrift in the directory Velox installed the dependencies.Was this patch authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8
Generated-by: Claude Opus 4.8