Skip to content

[VL] Test-only draft: GlutenDeltaVariantWriteSuite fails without the fix (validates #12444)#12445

Closed
felipepessoto wants to merge 1 commit into
apache:mainfrom
felipepessoto:vl-variant-write-test-only
Closed

[VL] Test-only draft: GlutenDeltaVariantWriteSuite fails without the fix (validates #12444)#12445
felipepessoto wants to merge 1 commit into
apache:mainfrom
felipepessoto:vl-variant-write-test-only

Conversation

@felipepessoto

Copy link
Copy Markdown
Contributor

Warning

Draft — do not merge. This PR intentionally contains only the test, without the fix, to
validate that the test fails on an unpatched main. The actual fix lives in
#12444.

What changes are proposed in this pull request?

This PR adds only GlutenDeltaVariantWriteSuite (backends-velox, delta-4.0) — the regression
test from #12444without the accompanying GlutenOptimisticTransaction guard. Its sole
purpose is to prove the test is an effective regression test: on an unpatched main, with the
native Delta write path enabled, writing a variant column throws
UnsupportedOperationException: Unsupported data type: variant, so the suite is expected to fail
on this branch.

The spark-test-spark40 job in velox_backend_x86.yml runs
-Pspark-4.0 -Pscala-2.13 -Pbackends-velox -Pdelta -Pspark-ut (no suite tags exclude it), so it
includes this suite. That job is expected to fail here and to pass once #12444's fix is applied.

How was this patch tested?

Not applicable — this branch is expected to fail CI by design. See #12444 for the fix together with
the passing tests.

Was this patch authored or co-authored using generative AI tooling?

Generated-by: GitHub Copilot CLI (Claude Opus 4.8)

@github-actions github-actions Bot added the VELOX label Jul 4, 2026
@felipepessoto

Copy link
Copy Markdown
Contributor Author

…thout the fix)

Adds only GlutenDeltaVariantWriteSuite, WITHOUT the GlutenOptimisticTransaction
guard from apache#12444, to demonstrate that the suite fails on an
unpatched main: with native Delta write enabled, the Velox write path throws
`UnsupportedOperationException: Unsupported data type: variant` at runtime.

Do not merge -- this PR exists only to validate that the test is an effective
regression test for apache#12444.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@felipepessoto felipepessoto force-pushed the vl-variant-write-test-only branch from b73e49e to 680b9e5 Compare July 4, 2026 21:04
@felipepessoto

Copy link
Copy Markdown
Contributor Author

✅ CI validation: the tests fail without the fix, for the expected reason

This draft intentionally contains only the test suite, without the fix. The spark-test-spark40 and spark-test-spark41 jobs failed exactly as intended — confirming GlutenDeltaVariantWriteSuite is an effective regression guard.

All three tests fail on unpatched main, each with the identical root cause the fix targets:

org.apache.spark.SparkException: Job aborted due to stage failure:
  java.lang.UnsupportedOperationException: Unsupported data type: variant
    at org.apache.spark.sql.utils.SparkArrowUtil$.toArrowType(SparkArrowUtil.scala:60)
    at org.apache.spark.sql.utils.SparkArrowUtil$.toArrowField(SparkArrowUtil.scala:137)
    at org.apache.spark.sql.utils.SparkArrowUtil$.$anonfun$toArrowSchema$1(SparkArrowUtil.scala:167)
    ... (RowToVeloxColumnarExec — the offloaded native Delta write path)
Workflow Job Suite result
Velox Backend (x86) spark-test-spark40 ❌ 3/3 tests failed (variant)
Velox Backend (x86) spark-test-spark41 ❌ 3/3 tests failed (variant)
Velox Backend (Enhanced) spark-test-spark40 ❌ 3/3 tests failed (variant)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant