[VL] Test-only draft: GlutenDeltaVariantWriteSuite fails without the fix (validates #12444)#12445
Closed
felipepessoto wants to merge 1 commit into
Closed
[VL] Test-only draft: GlutenDeltaVariantWriteSuite fails without the fix (validates #12444)#12445felipepessoto wants to merge 1 commit into
felipepessoto wants to merge 1 commit into
Conversation
Contributor
Author
…thout the fix) Adds only GlutenDeltaVariantWriteSuite, WITHOUT the GlutenOptimisticTransaction guard from apache#12444, to demonstrate that the suite fails on an unpatched main: with native Delta write enabled, the Velox write path throws `UnsupportedOperationException: Unsupported data type: variant` at runtime. Do not merge -- this PR exists only to validate that the test is an effective regression test for apache#12444. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
b73e49e to
680b9e5
Compare
Contributor
Author
✅ CI validation: the tests fail without the fix, for the expected reasonThis draft intentionally contains only the test suite, without the fix. The All three tests fail on unpatched
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Warning
Draft — do not merge. This PR intentionally contains only the test, without the fix, to
validate that the test fails on an unpatched
main. The actual fix lives in#12444.
What changes are proposed in this pull request?
This PR adds only
GlutenDeltaVariantWriteSuite(backends-velox, delta-4.0) — the regressiontest from #12444 — without the accompanying
GlutenOptimisticTransactionguard. Its solepurpose is to prove the test is an effective regression test: on an unpatched
main, with thenative Delta write path enabled, writing a variant column throws
UnsupportedOperationException: Unsupported data type: variant, so the suite is expected to failon this branch.
The
spark-test-spark40job invelox_backend_x86.ymlruns-Pspark-4.0 -Pscala-2.13 -Pbackends-velox -Pdelta -Pspark-ut(no suite tags exclude it), so itincludes this suite. That job is expected to fail here and to pass once #12444's fix is applied.
How was this patch tested?
Not applicable — this branch is expected to fail CI by design. See #12444 for the fix together with
the passing tests.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: GitHub Copilot CLI (Claude Opus 4.8)