[MINOR][VL][TEST] Drop dead Spark 3.2 TPC-H golden plans#12548
Open
LuciferYang wants to merge 1 commit into
Open
[MINOR][VL][TEST] Drop dead Spark 3.2 TPC-H golden plans#12548LuciferYang wants to merge 1 commit into
LuciferYang wants to merge 1 commit into
Conversation
Now that Gluten no longer supports Spark 3.2:
* `VeloxTPCHSuite.shouldCheckGoldenFiles`: drop the `case "32" => true`
branch. `formatSparkVersion` cannot be `"32"` on any supported profile
(3.3+), so the branch is unreachable.
* Remove the four `tpch-approved-plan/{v1,v1-bhj,v1-ras,v1-bhj-ras}/spark32/`
directories and their 84 golden `.txt` files. They were only loaded when
the pruned branch matched and are unreferenced now.
The 3.3 / 3.4 / 3.5 golden plans (and their case branches) are kept as-is.
No behavior change on any supported Spark version.
Contributor
Author
|
cc @jackylee-ch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow-up to #12525 / #12541 / #12543. Now that Gluten no longer supports Spark 3.2, the TPC-H golden plans for Spark 3.2 are dead test fixtures.
backends-velox/.../VeloxTPCHSuite.scala: drop thecase "32" => truebranch inshouldCheckGoldenFiles.formatSparkVersionis derived fromspark.version.substring(0, 2)and can never be"32"on any supported profile (Spark 3.3+), so the branch is unreachable.backends-velox/src/test/resources/tpch-approved-plan/{v1,v1-bhj,v1-ras,v1-bhj-ras}/spark32/: remove all fourspark32/subdirectories and their 84 golden.txtfiles. They were only loaded viatpch-approved-plan/${subType()}/spark$formatSparkVersion/$id.txtwhen the pruned branch matched.The
spark33/spark34/spark35case branches and golden plan directories are kept as-is. No behavior change on any supported Spark version.How was this patch tested?
./build/mvn -Pbackends-velox -Pspark-3.5 -pl backends-velox -am test-compile -DskipTests: SUCCESS./dev/format-scala-code.sh: no additional diffgrep -r "tpch-approved-plan|spark32"confirmsVeloxTPCHSuite.scalais the only Scala/Java caller and the only remaining references tospark32outside this diff are catalogued for follow-up cleanup (dev/*.sh,LICENSE,package/pom.xml), which are intentionally out of scope for this test-infrastructure PR.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude claude-opus-4-7