[GLUTEN-12387][VL] Re-enable large deletion vector tests - #12866
Closed
felipepessoto wants to merge 1 commit into
Closed
[GLUTEN-12387][VL] Re-enable large deletion vector tests#12866felipepessoto wants to merge 1 commit into
felipepessoto wants to merge 1 commit into
Conversation
Remove the CI force-failure injection and expected-failure entries for the two 2-billion-row DeletionVectorsSuite tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Re-enables Delta’s two large deletion-vector tests after the underlying fixes were merged.
Changes:
- Removes forced test failures.
- Removes obsolete known-failure entries.
- Updates workflow memory documentation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/util/delta-spark-ut/setup-delta.sh |
Re-enables normal test execution. |
.github/workflows/util/delta-spark-ut/known-failures.txt |
Removes the two obsolete failure entries. |
.github/workflows/delta_spark_ut.yml |
Updates memory documentation. |
Suppressed comments (1)
.github/workflows/util/delta-spark-ut/setup-delta.sh:175
- Removing this block also removes its
INJECTED == 2assertion.DELTA_REFis workflow-dispatchable (seesetup-delta.sh:66), and the aggregate gate only evaluates tests that emit reports, so a future Delta ref that renames or removes either test will silently pass without enforcing these regressions. Keep a read-only presence check for both test-name strings while dropping only the fail injection.
echo "::group::Disabling Delta scalastyle HeaderMatchesChecker"
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
Shard 2 is hanging for 4h30m. Closing the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
The deletion-vector planning, filtering, and file-I/O improvements tracked by #12399 are now merged. Remove the workaround added for #12387 so Delta's two 2-billion-row
DeletionVectorsSuitetests run normally again:setup-delta.shCloses #12387.
How was this patch tested?
bash -n .github/workflows/util/delta-spark-ut/setup-delta.shgit diff --checkWas this patch authored or co-authored using generative AI tooling?
Generated-by: GitHub Copilot CLI 1.0.80