Clean up Grails 8 Hibernate 7 TODO drift

[jamesfredley]

Why

This is a maintenance cleanup for the Grails 8 / Hibernate 7 branch. The branch had several stale migration breadcrumbs after the Hibernate 7 work landed: outdated agent guidance, stale Micronaut BOM comments, a Forge dependency pin that drifted from the root value, and TODO/FIXME comments that no longer described actionable follow-up.

What changed

• Updated repository and agent guidance to the current Grails 8 baseline: Java 21, Groovy 5, Spring Boot 4.1, Gradle 9.6, and Spock 2.4 for Groovy 5.
• Refreshed the Hibernate Micronaut BOM Jackson exclusion comments so they describe the current Micronaut platform relationship rather than the old milestone wording.
• Aligned Grails Forge picocliVersion with the root 4.7.6 pin.
• Removed or clarified stale Hibernate 7 TODO/FIXME comments across packaging, core/session context, domain binding, query helpers, and tests.

Behavior impact

The Hibernate 7 edits are comment-only and do not change runtime behavior, public APIs, mappings, generated SQL, or test assertions. The only non-comment build input change is the Forge Picocli patch-version alignment from 4.7.5 to 4.7.6.

Verification

• ./gradlew.bat :grails-data-hibernate7:compileJava :grails-data-hibernate7:compileGroovy :grails-data-hibernate7:compileTestJava :grails-data-hibernate7:compileTestGroovy passed.
• Full branch review-gate passed with Oracle GREEN and Codex reporting no branch-diff correctness issue.
• TestLens reported all tests passed for commit 12aa6e7b8592de5931b3db2819dcf06f9f6a8dcc.

Known unrelated blockers observed locally

• ./gradlew.bat compileJava from grails-forge currently reaches :grails-core:grails-validation:compileGroovy and fails because grails-validation/src/main/groovy/grails/validation/Validateable.groovy cannot resolve groovy.transform.Virtual.
• Earlier aggregate verification also hit unrelated :grails-data-graphql-core:compileGroovy static type checking errors for Arguable#withDelegate and ComplexTyped#withDelegate.

[Copilot]

Pull request overview

This PR refreshes Grails 8 / Hibernate 7 maintenance breadcrumbs by updating agent guidance to the current baseline, aligning a Forge dependency pin with the root, and removing/clarifying stale TODOs without changing runtime behavior.

Changes:

• Update agent docs/skills to reflect the Grails 8 baseline (Java 21, Groovy 5, Spring Boot 4.1, Gradle 9.6, Spock 2.4).
• Align Grails Forge’s Picocli pin with the root version.
• Remove or replace stale Hibernate 7 migration TODO/FIXME comments across Hibernate 7 modules, tests, and BOM notes.

Reviewed changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
grails-forge/gradle.properties	Align picocliVersion with root pin.
grails-data-hibernate7/grails-plugin/src/main/groovy/grails/plugin/hibernate/HibernateGrailsPlugin.groovy	Replace placeholder TODO with a clarifying no-op onChange comment.
grails-data-hibernate7/dbmigration/build.gradle	Remove stale TODOs; clarify Groovy exclusion rationale (one wording nit noted).
grails-data-hibernate7/dbmigration-core/src/test/java/liquibase/harness/diff/Posts.java	Remove stale inline TODO in test fixture.
grails-data-hibernate7/core/src/test/groovy/org/grails/orm/hibernate/HibernateGormStaticApiSpec.groovy	Remove stale TODO comment.
grails-data-hibernate7/core/src/test/groovy/grails/gorm/tests/WhereQueryWithAssociationSortSpec.groovy	Remove stale TODO comment.
grails-data-hibernate7/core/src/test/groovy/grails/gorm/tests/services/DataServiceSpec.groovy	Replace uncertain TODO with a clearer assertion intent comment.
grails-data-hibernate7/core/src/test/groovy/grails/gorm/tests/hasmany/HasManyWithInQuerySpec.groovy	Remove stale TODO comment.
grails-data-hibernate7/core/src/test/groovy/grails/gorm/tests/ExecuteQueryWithinValidatorSpec.groovy	Remove stale TODO comment.
grails-data-hibernate7/core/src/test/groovy/grails/gorm/tests/detachedcriteria/DetachedCriteriaJoinSpec.groovy	Remove commented-out TODO block that implied incorrect expectations.
grails-data-hibernate7/core/src/test/groovy/grails/gorm/tests/compositeid/GlobalConstraintWithCompositeIdSpec.groovy	Remove date-stamped TODO comment.
grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/query/JpaQueryContext.java	Replace TODO with explanatory Javadoc about shared alias/join scope.
grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/query/HqlQueryContext.java	Remove stale “TODO Cleanup” comment.
grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/query/HqlListQueryBuilder.java	Remove stale “TODO Cleanup” comment.
grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/query/AliasMapEntryFunction.java	Replace placeholder Javadoc with a descriptive class comment.
grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/HibernateSession.java	Remove multiple generic cleanup TODO comments.
grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/HibernateGormStaticApi.groovy	Remove “TODO Duplication!!” comment.
grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/HibernateDatastore.java	Replace TODO with a future-facing but non-TODO architectural note.
grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/GrailsSessionContext.java	Replace TODO with rationale for allowCreate=false default.
grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/util/TableForManyCalculator.java	Remove stale TODO comment.
grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/util/NamingStrategyProvider.java	Remove stale TODO comment.
grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/secondpass/CollectionSecondPassBinder.java	Reword TODO into future-major-release note about binder wiring.
grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/generator/GrailsNativeGenerator.java	Remove stale “Hacky implementation” TODO comment.
grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/PropertyBinder.java	Remove stale TODO comment.
grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/cfg/domainbinding/binder/ComponentBinder.java	Reword TODO into future-major-release note about circular dependency cleanup.
grails-data-hibernate7/boot-plugin/build.gradle	Remove stale TODO dependency comment.
grails-bom/hibernate7-micronaut/build.gradle	Refresh Jackson exclusion rationale comment.
grails-bom/hibernate5-micronaut/build.gradle	Refresh Jackson exclusion rationale comment.
AGENTS.md	Update baseline versions and resource links to match current Grails 8 stack.
.agents/skills/java-developer/SKILL.md	Update skill guidance to Java 21 baseline and docs links.
.agents/skills/groovy-developer/SKILL.md	Update skill guidance to Groovy 5 baseline and docs links.
.agents/skills/grails-developer/SKILL.md	Update skill guidance to Spring Boot 4.1 / Groovy 5 / Spock 2.4 baseline.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[testlens-app]

✅ All tests passed ✅

🏷️ Commit: 7eb91ad
▶️ Tests: 18197 executed
⚪️ Checks: 44/44 completed

---

Learn more about TestLens at testlens.app.