Allow concurrent documentation publishing - #16110
Open
jamesfredley wants to merge 1 commit into
Open
Conversation
Remove the repository-local documentation queue so independent publishers can run in parallel once the action-level optimistic retry is available. Assisted-by: opencode:gpt-5.6-sol
Contributor
|
I'm confused, we discussed this in the weekly and I made my objection clear to this. Yet you seem to have gone in the opposite direction. |
Contributor
Author
|
@jdaugherty do you have a solution that covers everything listed above? This wasted 3.5 hours this morning, that I did not have. |
Contributor
|
Yes, I mentioned it on the call. We should be uploading these artifacts and then having a separate workflow to process them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends On
This PR must not merge until apache/grails-github-actions#110 is merged to
asfand the updateddeploy-github-pages@asfref is verified.Summary
Remove the job-level
grails-docs-publishqueue from snapshot and release documentation publishing. Once the action-level optimistic retry is available, independent documentation jobs can run in parallel and let Git's normal fast-forward rules coordinate updates to the destination branch.The diff removes only the two queue declarations added by #15988. It does not change documentation generation, credentials, destination paths, action references, or workflow-level release coordination.
Why Remove the Queue
GitHub Actions concurrency groups coordinate runs only within one repository. Grails Core,
grails-static-website, and future publishers such as Grails Forge can all target the same website repository, but agrails-docs-publishgroup in Grails Core cannot coordinate those other repositories. The manualrelease-publish-docs.ymlworkflow is also a publisher and has never used this group.Within Grails Core, the static group makes unrelated release documentation jobs serial:
This turned a parallel release sequence into a serial one and required manual retriggering.
Replacement Safety
apache/grails-github-actions#110 retries only genuine non-fast-forward races. It fetches the new destination tip into the existing shallow checkout, verifies descendant history, rebases the unpublished local deployment commit, and retries a normal push. It never force-pushes or auto-resolves true conflicts.
Merge order is therefore mandatory:
asf.deploy-github-pages@asfcontains the retry implementation.7.0.x.Preserved Concurrency
The workflow-level
release-pipeline-${{ github.event.release.target_commitish }}group remains unchanged. This PR removes only the documentation publishing mutex.Verification
git diff --checkpasses.grails-docs-publishno longer appears in.github/workflows.release-publish-docs.ymlis byte-identical.