GRAILS-6922 - In scaffolding, allow for generate-* scripts to specify a controller name for which scaffolds should be generated#23
Closed
dmurat wants to merge 3 commits intoapache:1.3.xfrom
Conversation
…at/grails-core into 0009-scaffoldingControllerNameParam
Contributor
Author
|
Please note that there is one braking change. If templates are already installed with "install-templates" command, one need to change "className" to "controllerName" in "Controller.groovy" template's first line. This is not big change I think, but it is braking and this should be explained in release notes if this issue is going to be accepted. |
jdaugherty
pushed a commit
to jdaugherty/grails-core
that referenced
this pull request
Feb 9, 2025
Update to Micronaut 1.3.6
jdaugherty
pushed a commit
to jdaugherty/grails-core
that referenced
this pull request
Apr 19, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jdaugherty
pushed a commit
that referenced
this pull request
May 1, 2025
…keleton/client/ssri-6.0.2 Bump ssri from 6.0.1 to 6.0.2 in /skeleton/client
jdaugherty
pushed a commit
that referenced
this pull request
May 1, 2025
…keleton/client/dns-packet-1.3.4 Bump dns-packet from 1.3.1 to 1.3.4 in /skeleton/client
jdaugherty
pushed a commit
that referenced
this pull request
May 1, 2025
Update base profile to 5.0.0
jdaugherty
pushed a commit
that referenced
this pull request
May 1, 2025
Merge branch '6.0.x' into 7.0.x
jdaugherty
pushed a commit
to jdaugherty/grails-core
that referenced
this pull request
Jun 28, 2025
…-driver-sync-4.x Update dependency org.mongodb:mongodb-driver-sync to v4.11.0
jamesfredley
added a commit
that referenced
this pull request
May 3, 2026
…23 The 'instanceof' smart-cast bug tracked as GROOVY-11983 (fix committed 2026-05-03 to GROOVY_5_0_X as 65d16eb4, port from master af95d66d) lands in 5.0.6-SNAPSHOT build #23 (5.0.6-20260503.065745-23). Two workarounds that the audit on 2026-04-27 had attributed to that smart-cast misfire are no longer required against build #23: 1. PersistentEntityCodec.OneToManyDecoder/OneToManyEncoder ManyToMany.isAssignableFrom(property.getClass()) reverts to property instanceof ManyToMany. Verified against build #23 with: ./gradlew :grails-data-mongodb-core:test --tests 'org.grails.datastore.gorm.mongo.SimpleHasManySpec' --tests 'org.grails.datastore.gorm.mongo.CircularOneToManySpec' --tests 'org.grails.datastore.gorm.mongo.ListOneToManyOrderingSpec' --tests 'org.grails.datastore.gorm.mongo.EmbeddedListWithCustomTypeSpec' --tests 'org.grails.datastore.gorm.mongo.BrokenManyToManyAssociationSpec' --tests 'org.grails.datastore.gorm.mongo.OneToManyWithInheritanceSpec' --tests 'org.grails.datastore.gorm.mongo.CircularBidirectionalOneToManySpec' BUILD SUCCESSFUL. 2. DefaultHalViewHelper instanceof cascade order is reverted from ToOne-first / ToMany-second back to the original ToMany-first / ToOne-second. The 'reorder ToOne before ToMany to avoid Groovy 5 flow-typing narrowing conflict' from 153e14c was the same smart-cast misfire. Verified against build #23 with: ./gradlew :grails-views-gson:test BUILD SUCCESSFUL (all view rendering specs pass). Net result: 14 lines of workaround comments and 4 lines of swapped condition order removed. Three of the eight original Groovy 5 workarounds in this PR have now been retired by upstream Groovy fixes (GROOVY-11907 in 5.0.5, GROOVY-11968 in 5.0.6 build #22, GROOVY-11983 in 5.0.6 build #23). Assisted-by: claude-code:claude-opus-4.6
jamesfredley
added a commit
that referenced
this pull request
May 3, 2026
Two unrelated reverts pulled out of the Groovy 5 audit set in response to jdaugherty PR feedback: 1. Restore SUCCESS / FAILURE constant references across 9 scaffolding command files (CreateScaffoldControllerCommand, CreateScaffoldServiceCommand, GenerateAllCommand, GenerateAsyncControllerCommand, GenerateControllerCommand, GenerateScaffoldAllCommand, GenerateServiceCommand, GenerateViewsCommand, InstallTemplatesCommand). The earlier inline-to-true/false rewrite (commit d2441fb) had been driven by the GROOVY-11907 trait-static-fields bytecode bug, which is fixed in 5.0.5 and (with GROOVY-11968 follow-up) in 5.0.6 build #22. The CommandLineHelper trait still defines the constants, so the references resolve cleanly. ./gradlew :grails-scaffolding:test passes against 5.0.6-SNAPSHOT build #23. 2. Revert the unrelated 'defaultMessage ?: codes[0]' tweak in ValidationTagLib. It was a behavioural change (prefer i18n defaultMessage over the raw error code) bundled into the Groovy 5 sweep but is not Groovy-version conditional. Per jdaugherty review, it should be a separate PR. Assisted-by: claude-code:claude-opus-4.6
This was referenced May 3, 2026
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More info at http://jira.codehaus.org/browse/GRAILS-6922