Skip to content

[#11053] improvement(deps): Upgrade Log4j from 2.24.3 to 2.25.4 - #11054

Merged
diqiu50 merged 1 commit into
apache:mainfrom
geyanggang:issue-11053
May 12, 2026
Merged

[#11053] improvement(deps): Upgrade Log4j from 2.24.3 to 2.25.4#11054
diqiu50 merged 1 commit into
apache:mainfrom
geyanggang:issue-11053

Conversation

@geyanggang

Copy link
Copy Markdown
Collaborator

What changes were proposed in this pull request?

Upgrade Log4j from 2.24.3 to 2.25.4 in gradle/libs.versions.toml.

Why are the changes needed?

Log4j 2.25.4 includes fixes for log injection, malformed XML/JSON output, and improved configuration attribute handling. Keeping dependencies up to date reduces the surface area flagged by security scanners and ensures we benefit from upstream bug fixes.

Gravitino uses only standard PatternLayout with common date patterns (%d{yyyy-MM-dd HH:mm:ss.SSS}), so the behavioral changes introduced in 2.25.0 (date formatting, exception converter defaults) do not affect the project.

Fix: #11053

Does this PR introduce any user-facing change?

No. The logging output format remains unchanged since Gravitino uses explicit date patterns that are compatible across versions.

How was this patch tested?

  • ./gradlew :core:test :server:test -PskipITs — all tests pass
  • ./gradlew :catalogs:hive-metastore-common:test :iceberg:iceberg-common:test -PskipITs — all tests pass
  • Compilation verified across core, server, and api modules

@geyanggang geyanggang self-assigned this May 12, 2026
@geyanggang
geyanggang requested a review from diqiu50 May 12, 2026 08:49
@github-actions

Copy link
Copy Markdown

Code Coverage Report

Overall Project 65.93% 🟢
Files changed No Java source files changed -

Module Coverage
aliyun 1.72% 🔴
api 47.13% 🟢
authorization-common 85.96% 🟢
aws 1.08% 🔴
azure 2.47% 🔴
catalog-common 10.2% 🔴
catalog-fileset 80.02% 🟢
catalog-glue 82.47% 🟢
catalog-hive 81.83% 🟢
catalog-jdbc-clickhouse 79.18% 🟢
catalog-jdbc-common 43.93% 🟢
catalog-jdbc-doris 80.28% 🟢
catalog-jdbc-hologres 54.03% 🟢
catalog-jdbc-mysql 79.23% 🟢
catalog-jdbc-oceanbase 78.38% 🟢
catalog-jdbc-postgresql 82.05% 🟢
catalog-jdbc-starrocks 78.27% 🟢
catalog-kafka 77.01% 🟢
catalog-lakehouse-generic 45.14% 🟢
catalog-lakehouse-hudi 79.1% 🟢
catalog-lakehouse-iceberg 86.98% 🟢
catalog-lakehouse-paimon 76.85% 🟢
catalog-model 77.72% 🟢
cli 44.51% 🟢
client-java 77.96% 🟢
common 50.0% 🟢
core 82.14% 🟢
filesystem-hadoop3 76.97% 🟢
flink 0.0% 🔴
flink-common 43.17% 🟢
flink-runtime 0.0% 🔴
gcp 14.12% 🔴
hadoop-common 10.39% 🔴
hive-metastore-common 46.83% 🟢
iceberg-common 55.46% 🟢
iceberg-rest-server 69.61% 🟢
idp-basic 94.68% 🟢
integration-test-common 0.0% 🔴
jobs 66.17% 🟢
lance-common 19.95% 🔴
lance-rest-server 62.78% 🟢
lineage 53.02% 🟢
optimizer 82.87% 🟢
optimizer-api 21.95% 🔴
server 85.8% 🟢
server-common 71.21% 🟢
spark 32.79% 🔴
spark-common 39.09% 🔴
trino-connector 35.14% 🔴

@diqiu50 diqiu50 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diqiu50
diqiu50 merged commit a4ff285 into apache:main May 12, 2026
29 checks passed
danhuawang pushed a commit to danhuawang/gravitino that referenced this pull request Jun 8, 2026
…apache#11054)

### What changes were proposed in this pull request?

Upgrade Log4j from 2.24.3 to 2.25.4 in `gradle/libs.versions.toml`.

### Why are the changes needed?

Log4j 2.25.4 includes fixes for log injection, malformed XML/JSON
output, and improved configuration attribute handling. Keeping
dependencies up to date reduces the surface area flagged by security
scanners and ensures we benefit from upstream bug fixes.

Gravitino uses only standard PatternLayout with common date patterns
(`%d{yyyy-MM-dd HH:mm:ss.SSS}`), so the behavioral changes introduced in
2.25.0 (date formatting, exception converter defaults) do not affect the
project.

Fix: apache#11053 

### Does this PR introduce _any_ user-facing change?

No. The logging output format remains unchanged since Gravitino uses
explicit date patterns that are compatible across versions.

### How was this patch tested?

- `./gradlew :core:test :server:test -PskipITs` — all tests pass
- `./gradlew :catalogs:hive-metastore-common:test
:iceberg:iceberg-common:test -PskipITs` — all tests pass
- Compilation verified across core, server, and api modules
danhuawang pushed a commit to danhuawang/gravitino that referenced this pull request Jun 9, 2026
…apache#11054)

### What changes were proposed in this pull request?

Upgrade Log4j from 2.24.3 to 2.25.4 in `gradle/libs.versions.toml`.

### Why are the changes needed?

Log4j 2.25.4 includes fixes for log injection, malformed XML/JSON
output, and improved configuration attribute handling. Keeping
dependencies up to date reduces the surface area flagged by security
scanners and ensures we benefit from upstream bug fixes.

Gravitino uses only standard PatternLayout with common date patterns
(`%d{yyyy-MM-dd HH:mm:ss.SSS}`), so the behavioral changes introduced in
2.25.0 (date formatting, exception converter defaults) do not affect the
project.

Fix: apache#11053 

### Does this PR introduce _any_ user-facing change?

No. The logging output format remains unchanged since Gravitino uses
explicit date patterns that are compatible across versions.

### How was this patch tested?

- `./gradlew :core:test :server:test -PskipITs` — all tests pass
- `./gradlew :catalogs:hive-metastore-common:test
:iceberg:iceberg-common:test -PskipITs` — all tests pass
- Compilation verified across core, server, and api modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] Upgrade Log4j from 2.24.3 to 2.25.4

2 participants