[#11170] fix(audit): Add ListEvent interface with resultCount to list events and surface count in audit log by jerryshao · Pull Request #11199 · apache/gravitino

jerryshao · 2026-05-22T07:48:49Z

What changes were proposed in this pull request?

Introduces a ListEvent marker interface that exposes resultCount() on all
list-operation success event classes (core and Iceberg REST server). All event
dispatchers are updated to pass the actual result count when constructing these
events. SimpleAuditLogV2.toString() now surfaces the count as {count=N} in
the custom-info audit-log field.

Backward compatibility is preserved: the original no-count constructors are
deprecated and delegate to -1; the audit formatter omits the count field when
resultCount() returns -1.

Why are the changes needed?

Without the result count in audit logs it is impossible to distinguish an
empty list response from a non-empty one, making audit trails less useful for
security analysis and capacity planning.

Fix: #11170

Does this PR introduce any user-facing change?

New ListEvent interface added to the public @DeveloperApi surface.
All List*Event classes gain a new preferred constructor that accepts a result
count; the old constructors are deprecated but still compile and run.
Audit log lines for list operations now include {count=N} in the last field.

How was this patch tested?

TestSimpleAuditLogV2: new tests cover count in log output, zero count, null
identifier, count merged with custom info, deprecated constructor omitting
count, and non-list events.
TestFileAuditWriter: end-to-end log-line tests for ListTableEvent,
ListMetalakeEvent, and ListCatalogEvent.
Existing dispatcher and event tests updated to use the new constructors.

github-actions · 2026-05-22T09:02:50Z

Code Coverage Report

Overall Project	66.58% `+0.7%`	🟢
Files changed	94.92%	🟢

Module	Coverage
aliyun	1.72%	🔴
api	46.82%	🟢
authorization-common	85.96%	🟢
aws	2.66%	🔴
azure	2.47%	🔴
catalog-common	10.2%	🔴
catalog-fileset	80.02%	🟢
catalog-glue	66.08%	🟢
catalog-hive	79.75%	🟢
catalog-jdbc-clickhouse	80.02%	🟢
catalog-jdbc-common	44.46%	🟢
catalog-jdbc-doris	80.28%	🟢
catalog-jdbc-hologres	54.03%	🟢
catalog-jdbc-mysql	79.23%	🟢
catalog-jdbc-oceanbase	78.38%	🟢
catalog-jdbc-postgresql	82.17%	🟢
catalog-jdbc-starrocks	78.27%	🟢
catalog-kafka	77.01%	🟢
catalog-lakehouse-generic	44.89%	🟢
catalog-lakehouse-hudi	79.1%	🟢
catalog-lakehouse-iceberg	85.71%	🟢
catalog-lakehouse-paimon	79.29%	🟢
catalog-model	77.72%	🟢
cli	44.51%	🟢
client-java	77.94%	🟢
common	49.99%	🟢
core	82.36% `+0.9%`	🟢
filesystem-hadoop3	76.97%	🟢
flink	0.0%	🔴
flink-common	43.17%	🟢
flink-runtime	0.0%	🔴
gcp	14.12%	🔴
hadoop-common	10.39%	🔴
hive-metastore-common	53.26%	🟢
iceberg-common	54.98%	🟢
iceberg-rest-server	69.87% `+2.98%`	🟢
idp-basic	90.43%	🟢
integration-test-common	0.0%	🔴
jobs	66.17%	🟢
lance-common	20.83%	🔴
lance-rest-server	60.27%	🟢
lineage	53.02%	🟢
optimizer	82.95%	🟢
optimizer-api	21.95%	🔴
server	85.1%	🟢
server-common	72.85%	🟢
spark	32.79%	🔴
spark-common	39.09%	🔴
trino-connector	39.28%	🔴

Files

Module	File	Coverage
core	FilesetEventDispatcher.java	100.0%	🟢
	PolicyEventDispatcher.java	100.0%	🟢
	TagEventDispatcher.java	100.0%	🟢
	ListCatalogEvent.java	100.0%	🟢
	ListMetadataObjectsForTagEvent.java	100.0%	🟢
	ListMetalakeEvent.java	100.0%	🟢
	ListModelVersionInfosEvent.java	100.0%	🟢
	ListModelVersionsEvent.java	100.0%	🟢
	ListSchemaEvent.java	100.0%	🟢
	ListTableEvent.java	100.0%	🟢
	ListTagsForMetadataObjectEvent.java	100.0%	🟢
	ListTagsInfoForMetadataObjectEvent.java	100.0%	🟢
	ListFunctionInfosEvent.java	100.0%	🟢
	ListJobTemplatesEvent.java	100.0%	🟢
	ListMetadataObjectsForPolicyEvent.java	100.0%	🟢
	ListPoliciesEvent.java	100.0%	🟢
	ListPolicyInfosEvent.java	100.0%	🟢
	ListStatisticsEvent.java	100.0%	🟢
	MetalakeEventDispatcher.java	98.59%	🟢
	TableEventDispatcher.java	98.46%	🟢
	FunctionEventDispatcher.java	98.33%	🟢
	ViewEventDispatcher.java	98.21%	🟢
	ModelEventDispatcher.java	98.17%	🟢
	SchemaEventDispatcher.java	98.15%	🟢
	TopicEventDispatcher.java	98.15%	🟢
	CatalogEventDispatcher.java	97.67%	🟢
	JobEventDispatcher.java	97.12%	🟢
	AccessControlEventDispatcher.java	94.68%	🟢
	SimpleAuditLogV2.java	93.75%	🟢
	StatisticEventDispatcher.java	92.42%	🟢
	ListJobsEvent.java	88.89%	🟢
	ListPolicyInfosForMetadataObjectEvent.java	88.89%	🟢
	ListPartitionStatisticsEvent.java	88.89%	🟢
	PartitionEventDispatcher.java	86.49%	🟢
	ListFilesEvent.java	81.82%	🟢
	ListViewEvent.java	77.78%	🟢
	ListFilesetEvent.java	66.67%	🟢
	ListModelEvent.java	66.67%	🟢
	ListTopicEvent.java	66.67%	🟢
	ListFunctionEvent.java	66.67%	🟢
	ListRoleNamesEvent.java	61.54%	🟢
	ListGroupNamesEvent.java	57.14%	🔴
	ListGroupsEvent.java	57.14%	🔴
	ListPartitionEvent.java	57.14%	🔴
	ListPartitionNamesEvent.java	57.14%	🔴
	ListTagsEvent.java	57.14%	🔴
	ListTagsInfoEvent.java	57.14%	🔴
	ListUserNamesEvent.java	57.14%	🔴
	ListUsersEvent.java	57.14%	🔴
	ListEvent.java	0.0%	🔴
iceberg-rest-server	IcebergViewEventDispatcher.java	96.97%	🟢
	IcebergNamespaceEventDispatcher.java	96.88%	🟢
	IcebergTableEventDispatcher.java	95.2%	🟢
	IcebergListNamespacesEvent.java	85.71%	🟢
	IcebergListTableEvent.java	85.71%	🟢
	IcebergListViewEvent.java	85.71%	🟢

Copilot

Pull request overview

This PR enhances the audit/event model for “list” operations by introducing a ListEvent marker interface (with resultCount()), updating list-success events and dispatchers to capture the returned item count, and surfacing {count=N} in SimpleAuditLogV2 output for improved auditability.

Changes:

Add ListEvent interface and implement it across list-success events (core + Iceberg REST server), with new preferred constructors carrying a result count and deprecated no-count constructors defaulting to -1.
Update core and Iceberg REST event dispatchers to pass actual list result sizes into events.
Extend SimpleAuditLogV2.toString() to include {count=N} in the custom-info field for ListEvents, and add/adjust tests validating formatting and deprecated-constructor behavior.

Reviewed changes

Copilot reviewed 71 out of 71 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/service/rest/TestIcebergViewOperations.java	Assert `IcebergListViewEvent.resultCount()` and add deprecated-constructor coverage.
iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/service/rest/TestIcebergTableOperations.java	Assert `IcebergListTableEvent.resultCount()` and add deprecated-constructor coverage.
iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/service/rest/TestIcebergNamespaceOperations.java	Assert `IcebergListNamespacesEvent.resultCount()` (including empty list) and add deprecated-constructor coverage.
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/listener/api/event/IcebergListViewEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/listener/api/event/IcebergListTableEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/listener/api/event/IcebergListNamespacesEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/dispatcher/IcebergViewEventDispatcher.java	Dispatch `IcebergListViewEvent` with response size.
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/dispatcher/IcebergTableEventDispatcher.java	Dispatch `IcebergListTableEvent` with response size.
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/dispatcher/IcebergNamespaceEventDispatcher.java	Dispatch `IcebergListNamespacesEvent` with response size.
core/src/test/java/org/apache/gravitino/listener/api/event/TestTopicEvent.java	Adjust list mock to return empty array (non-null) for count calculation.
core/src/test/java/org/apache/gravitino/listener/api/event/TestTagEvent.java	Validate `resultCount()` on tag list events; add deprecated-constructor tests.
core/src/test/java/org/apache/gravitino/listener/api/event/TestTableEvent.java	Validate `ListTableEvent.resultCount()`; update mocks and add deprecated-constructor test.
core/src/test/java/org/apache/gravitino/listener/api/event/TestStatisticsEventDispatcher.java	Validate `resultCount()` for statistics list events; add deprecated-constructor tests.
core/src/test/java/org/apache/gravitino/listener/api/event/TestSchemaEvent.java	Validate `ListSchemaEvent.resultCount()`; update mocks and add deprecated-constructor test.
core/src/test/java/org/apache/gravitino/listener/api/event/TestPolicyEvent.java	Validate `resultCount()` for policy list events; add deprecated-constructor tests.
core/src/test/java/org/apache/gravitino/listener/api/event/TestPartitionEvent.java	Adjust list mocks to return empty arrays (non-null) for count calculation.
core/src/test/java/org/apache/gravitino/listener/api/event/TestMetalakeEvent.java	Validate `ListMetalakeEvent.resultCount()` including empty list; update mock and add deprecated-constructor test.
core/src/test/java/org/apache/gravitino/listener/api/event/TestJobEventDispatcher.java	Validate `resultCount()` for job list events; add deprecated-constructor tests.
core/src/test/java/org/apache/gravitino/listener/api/event/TestFunctionEvent.java	Adjust list mock to return empty array (non-null) for count calculation.
core/src/test/java/org/apache/gravitino/listener/api/event/TestFilesetEvent.java	Adjust list mock to return empty array (non-null) for count calculation.
core/src/test/java/org/apache/gravitino/listener/api/event/TestCatalogEvent.java	Validate `ListCatalogEvent.resultCount()` for both name/info listing; update mocks and add deprecated-constructor test.
core/src/test/java/org/apache/gravitino/audit/v2/TestSimpleAuditLogV2.java	Add comprehensive tests for `{count=N}` rendering/omission and merging with custom info.
core/src/test/java/org/apache/gravitino/audit/TestOperation.java	Update list-operation tests to use new list-success constructors and reorder assert args.
core/src/test/java/org/apache/gravitino/audit/TestFileAuditWriter.java	Add end-to-end audit line tests verifying `{count=N}` in formatted output.
core/src/main/java/org/apache/gravitino/listener/TopicEventDispatcher.java	Emit `ListTopicEvent` with returned count.
core/src/main/java/org/apache/gravitino/listener/TagEventDispatcher.java	Emit tag-related list events with returned counts.
core/src/main/java/org/apache/gravitino/listener/TableEventDispatcher.java	Emit `ListTableEvent` with returned count.
core/src/main/java/org/apache/gravitino/listener/StatisticEventDispatcher.java	Emit statistics list events with returned counts.
core/src/main/java/org/apache/gravitino/listener/SchemaEventDispatcher.java	Emit `ListSchemaEvent` with returned count.
core/src/main/java/org/apache/gravitino/listener/PolicyEventDispatcher.java	Emit policy list events with returned counts.
core/src/main/java/org/apache/gravitino/listener/PartitionEventDispatcher.java	Emit partition list events with returned counts.
core/src/main/java/org/apache/gravitino/listener/ModelEventDispatcher.java	Emit `ListModelEvent` with returned count.
core/src/main/java/org/apache/gravitino/listener/MetalakeEventDispatcher.java	Emit `ListMetalakeEvent` with returned count.
core/src/main/java/org/apache/gravitino/listener/JobEventDispatcher.java	Emit job list events with returned counts.
core/src/main/java/org/apache/gravitino/listener/FunctionEventDispatcher.java	Emit `ListFunctionEvent` with returned count.
core/src/main/java/org/apache/gravitino/listener/FilesetEventDispatcher.java	Emit `ListFilesetEvent` with returned count.
core/src/main/java/org/apache/gravitino/listener/CatalogEventDispatcher.java	Emit `ListCatalogEvent` with returned count for both list APIs.
core/src/main/java/org/apache/gravitino/listener/api/event/stats/ListStatisticsEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/stats/ListPartitionStatisticsEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/policy/ListPolicyInfosForMetadataObjectEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/policy/ListPolicyInfosEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/policy/ListPoliciesEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/policy/ListMetadataObjectsForPolicyEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/ListUsersEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/ListUserNamesEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/ListTopicEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/ListTagsInfoForMetadataObjectEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/ListTagsInfoEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/ListTagsForMetadataObjectEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/ListTagsEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/ListTableEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/ListSchemaEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/ListRoleNamesEvent.java	Implement `ListEvent`; add count-aware constructors and deprecate no-count overloads.
core/src/main/java/org/apache/gravitino/listener/api/event/ListPartitionNamesEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/ListPartitionEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/ListModelVersionsEvent.java	Implement `ListEvent` with `resultCount()` derived from versions array length.
core/src/main/java/org/apache/gravitino/listener/api/event/ListModelVersionInfosEvent.java	Implement `ListEvent` with `resultCount()` derived from versions array length.
core/src/main/java/org/apache/gravitino/listener/api/event/ListModelEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/ListMetalakeEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/ListMetadataObjectsForTagEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/ListGroupsEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/ListGroupNamesEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/ListFilesetEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/ListEvent.java	New marker interface exposing `resultCount()` for list-success events.
core/src/main/java/org/apache/gravitino/listener/api/event/ListCatalogEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/job/ListJobTemplatesEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/job/ListJobsEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/api/event/function/ListFunctionInfosEvent.java	Implement `ListEvent` with `resultCount()` derived from returned array length.
core/src/main/java/org/apache/gravitino/listener/api/event/function/ListFunctionEvent.java	Implement `ListEvent`; add count-aware constructor + deprecated no-count constructor.
core/src/main/java/org/apache/gravitino/listener/AccessControlEventDispatcher.java	Emit user/group/role list events with returned counts.
core/src/main/java/org/apache/gravitino/audit/v2/SimpleAuditLogV2.java	Merge `{count=N}` into custom-info for `ListEvent`s and omit it for `-1`.

Copilot

Pull request overview

Copilot reviewed 71 out of 71 changed files in this pull request and generated 2 comments.

…log format - Problem 1: Rewrite FileAuditWriter to delegate file management (rotation, compression, retention) to Log4j2 via a dedicated SLF4J logger named 'gravitino.audit'. Add audit_file rolling appender to log4j2.properties.template (256 MB / daily rotation, gzip compression, 30-day retention). Deprecated writer properties (fileName, append, flushIntervalSecs) now emit WARN and are ignored. - Problem 3: Add RequestContext ThreadLocal to capture client IP on the servlet thread at Event construction time, so async listener threads read a field rather than accessing ThreadLocal. Add RequestContextFilter to set/clear the value around each request, honoring X-Forwarded-For for reverse-proxy setups. Apply the same X-Forwarded-For logic to IcebergRequestContext. - Problem 4: Fix SimpleAuditLogV2.toString() to use millisecond-precision timestamps (DateTimeFormatter, thread-safe) and append customInfo() as an 8th tab-separated field. - Update gravitino-server-config.md to document the Log4j2 migration path and mark the deprecated writer properties. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…o list events and surface count in audit log Introduces a ListEvent marker interface so all list-operation success events expose resultCount(). Dispatchers now pass the actual array/list length when constructing events. SimpleAuditLogV2.toString() surfaces the count as {count=N} in the custom-info field, omitting it when the deprecated no-count constructors are used (resultCount() == -1). Deprecated backward-compatible constructors are retained for existing callers. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- SimpleAuditLogV2: apply customInfo before inserting count so the event-derived count cannot be overwritten by a caller-supplied 'count' key in customInfo() - TestSimpleAuditLogV2: remove ordering dependency from testListEventCountMergedWithExistingCustomInfo – check presence of both keys without asserting insertion order - TestIcebergNamespaceOperations / TestIcebergTableOperations / TestIcebergViewOperations: replace fully-qualified org.apache.gravitino.NameIdentifier usages with an import and short name per project style guidelines Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- SimpleAuditLogV2: replace LinkedHashMap with List<String> for customInfo formatting to tolerate duplicate keys; event-derived count and any user-supplied 'count' in customInfo now both appear in the audit field rather than one silently overwriting the other - SimpleAuditLogV2: simplify toString() into a single linear flow (remove the if/else branch between list and non-list paths) - ListModelVersionsEvent/ListModelVersionInfosEvent: guard resultCount() against null versions array to prevent NPE in audit logging - IcebergTableEventDispatcher / IcebergViewEventDispatcher / IcebergNamespaceEventDispatcher: move success event dispatch inside the try-catch and null-guard the identifiers/namespaces list before calling size(), preventing NPE propagation for successful operations - TestSimpleAuditLogV2: add test for duplicate 'count' key collision Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

… count - ListViewEvent: implement ListEvent interface, add preferred constructor with viewCount, deprecate no-count constructor, add resultCount() - ViewEventDispatcher: pass identifiers.length to ListViewEvent - TestViewEvent: fix mock returning null for listViews (caused NPE with new identifiers.length call); add resultCount assertion - TestOperation: update to preferred ListViewEvent constructor Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 74 out of 74 changed files in this pull request and generated 11 comments.

…ers and fix FQN imports - Add null guards (array/list != null ? array.length/list.size() : 0) for all list event dispatchers: AccessControl, Catalog, Fileset, Function, Job, Metalake, Model, Partition, Policy, Schema, Statistic, Table, Tag, Topic, View - Fix NPE in ListFunctionInfosEvent constructor when functionInfos is null - Fix FQN usages in TestSimpleAuditLogV2 by using import statements Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 74 out of 74 changed files in this pull request and generated 18 comments.

@SuppressWarnings

… and add resultCount assertions - Change all list event dispatchers to pass -1 (not 0) when result array is null, so resultCount() correctly signals "not captured" vs. "empty result" - Fix ListModelVersionsEvent, ListModelVersionInfosEvent, and ListFunctionInfosEvent to store the raw array (null-safe) and derive resultCount() from it, removing the incorrect null→empty coercion - Expand ListFilesEvent to accept resultCount in its primary constructor and deprecate the old no-count constructor (with @SuppressWarnings for errorprone) - Add resultCount() assertions to TestFilesetEvent, TestModelEvent, and TestFunctionEvent to cover the -1/actual-count contract Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

mchades

lgtm.

…o list events and surface count in audit log (apache#11199) ### What changes were proposed in this pull request? Introduces a `ListEvent` marker interface that exposes `resultCount()` on all list-operation success event classes (core and Iceberg REST server). All event dispatchers are updated to pass the actual result count when constructing these events. `SimpleAuditLogV2.toString()` now surfaces the count as `{count=N}` in the custom-info audit-log field. Backward compatibility is preserved: the original no-count constructors are deprecated and delegate to `-1`; the audit formatter omits the count field when `resultCount()` returns `-1`. ### Why are the changes needed? Without the result count in audit logs it is impossible to distinguish an empty list response from a non-empty one, making audit trails less useful for security analysis and capacity planning. Fix: apache#11170 ### Does this PR introduce _any_ user-facing change? - New `ListEvent` interface added to the public `@DeveloperApi` surface. - All `List*Event` classes gain a new preferred constructor that accepts a result count; the old constructors are deprecated but still compile and run. - Audit log lines for list operations now include `{count=N}` in the last field. ### How was this patch tested? - `TestSimpleAuditLogV2`: new tests cover count in log output, zero count, null identifier, count merged with custom info, deprecated constructor omitting count, and non-list events. - `TestFileAuditWriter`: end-to-end log-line tests for `ListTableEvent`, `ListMetalakeEvent`, and `ListCatalogEvent`. - Existing dispatcher and event tests updated to use the new constructors. --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

jerryshao force-pushed the fix/audit-list-events-11170 branch from 5bf26ef to 8c4a66b Compare May 25, 2026 06:58

jerryshao marked this pull request as ready for review May 25, 2026 06:58

jerryshao requested a review from Copilot May 25, 2026 07:02

Copilot started reviewing on behalf of jerryshao May 25, 2026 07:02 View session

Copilot AI reviewed May 25, 2026

View reviewed changes

jerryshao requested a review from Copilot May 25, 2026 11:30

Copilot started reviewing on behalf of jerryshao May 25, 2026 11:30 View session

Copilot AI reviewed May 25, 2026

View reviewed changes

Comment thread core/src/test/java/org/apache/gravitino/audit/v2/TestSimpleAuditLogV2.java

Comment thread core/src/main/java/org/apache/gravitino/listener/api/event/ListEvent.java Outdated

jerryshao self-assigned this May 25, 2026

jerryshao and others added 6 commits May 26, 2026 10:13

Fix rebase conflicts

7d1ff08

jerryshao force-pushed the fix/audit-list-events-11170 branch from 3e13647 to d780164 Compare May 26, 2026 03:24

jerryshao requested review from Copilot and mchades May 26, 2026 03:24

Copilot started reviewing on behalf of jerryshao May 26, 2026 03:24 View session

Copilot AI reviewed May 26, 2026

View reviewed changes

jerryshao requested a review from Copilot May 26, 2026 06:42

Copilot started reviewing on behalf of jerryshao May 26, 2026 06:43 View session

Copilot AI reviewed May 26, 2026

View reviewed changes

mchades approved these changes May 26, 2026

View reviewed changes

jerryshao merged commit bb05b3f into apache:main May 27, 2026
35 of 36 checks passed

Uh oh!

Conversation

jerryshao commented May 22, 2026

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Uh oh!

github-actions Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mchades left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented May 22, 2026 •

edited

Loading