[#11335] setting web v2 ui as default - #11458
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Gravitino’s startup environment/templates so Web UI v2 becomes the default when GRAVITINO_USE_WEB_V2 is not explicitly set, aligning with issue #11335.
Changes:
- Default
GRAVITINO_USE_WEB_V2totrueinconf/gravitino-env.sh.template. - Update
bin/gravitino.sh.templateUI WAR selection logic to prefer v2 whenGRAVITINO_USE_WEB_V2is unset. - Refresh related inline comments to reflect the new default behavior.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| conf/gravitino-env.sh.template | Sets GRAVITINO_USE_WEB_V2 default to true via env var expansion and updates UI-selection comments. |
| bin/gravitino.sh.template | Changes WAR selection logic to prefer the v2 UI by default and updates explanatory comments. |
Comment on lines
+36
to
+39
| # - Default to the v2 UI when GRAVITINO_USE_WEB_V2 is unset. | ||
| # - If GRAVITINO_USE_WEB_V2 is already provided by container/k8s env, keep that value. | ||
| # - To force the v1 UI, set GRAVITINO_USE_WEB_V2=false. | ||
| export GRAVITINO_USE_WEB_V2=${GRAVITINO_USE_WEB_V2:-true} No newline at end of file |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Code Coverage Report
|
mchades
approved these changes
Jun 5, 2026
danhuawang
pushed a commit
to danhuawang/gravitino
that referenced
this pull request
Jun 8, 2026
### What changes were proposed in this pull request?
1. set `GRAVITINO_USE_WEB_V2=${GRAVITINO_USE_WEB_V2:-true}`
2. update comment
<img width="2684" height="1384" alt="image"
src="https://github.com/user-attachments/assets/a3234612-d0a2-4120-8c36-d215a0c35765"
/>
### Why are the changes needed?
N/A
Fix: apache#11335
### Does this PR introduce _any_ user-facing change?
N/A
### How was this patch tested?
manually
---------
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
danhuawang
pushed a commit
to danhuawang/gravitino
that referenced
this pull request
Jun 9, 2026
### What changes were proposed in this pull request?
1. set `GRAVITINO_USE_WEB_V2=${GRAVITINO_USE_WEB_V2:-true}`
2. update comment
<img width="2684" height="1384" alt="image"
src="https://github.com/user-attachments/assets/a3234612-d0a2-4120-8c36-d215a0c35765"
/>
### Why are the changes needed?
N/A
Fix: apache#11335
### Does this PR introduce _any_ user-facing change?
N/A
### How was this patch tested?
manually
---------
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
GRAVITINO_USE_WEB_V2=${GRAVITINO_USE_WEB_V2:-true}Why are the changes needed?
N/A
Fix: #11335
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
manually