[#12297] feat(secret): Support setSecretBinding/setSecretReference on catalog/schema alter - #12674
Merged
roryqi merged 8 commits intoAug 28, 2026
Conversation
…nce on catalog/schema alter Wire catalog/schema alter through SecretManager alter helpers and local prepare*SecretChanges loops, matching fileset and create-path style. Co-authored-by: Cursor <cursoragent@cursor.com>
…set pattern Extract alterCatalogUnderLock and alterSchemaUnderLock, prepare secret changes before persistence, and use the same rollback pattern as FilesetOperationDispatcher instead of AtomicReference inside store.update. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep secret preparation on the same entity snapshot as the catalog update to avoid stale-property races, while retaining alterCatalogUnderLock structure. Co-authored-by: Cursor <cursoragent@cursor.com>
…ecret flow Extract SecretAlterChanges and SecretMaterialsHolder, prepare secrets inside store.update for catalog, managed schema, and fileset catalog, while keeping dispatcher-side prepare for non-fileset test catalogs. Co-authored-by: Cursor <cursoragent@cursor.com>
Merge alter-remove secret checks into existing create tests, consolidate JSON secret update serde into one test, and rename masked-placeholder tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Only use managed-schema store.update path when schema ops is ManagedSchemaOperations, so Kafka default-schema guards still apply. Also remove unused Dict import in Python schema_change. Co-authored-by: Cursor <cursoragent@cursor.com>
Tolerate loadSchema failures in external schema alter so catalogs like Hudi can still throw their own UnsupportedOperationException. Co-authored-by: Cursor <cursoragent@cursor.com>
Code Coverage Report
Files
|
roryqi
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow-up to #12646 (fileset alter). Adds catalog / schema alter support for
setSecretBinding/setSecretReference:CatalogChangeandSchemaChangetypesCatalogManager/SchemaOperationDispatcher: localprepare*SecretChangesloops calling existingSecretManageralter helpers, rewriting secret ops tosetProperty/removeProperty(same pattern asFilesetOperationDispatcher)OperationDispatcher: validate alter upserts for schema secret changesWhy are the changes needed?
Create-time
secretBindings/secretReferencesfor catalog and schema are already onmain(#12420). Catalog and schema alter still need the typed secret update contract from the entity-secrets design (§5.9.4).Fix: #12297
Does this PR introduce any user-facing change?
Yes. Catalog and schema alter APIs / REST update requests gain
setSecretBindingandsetSecretReference.How was this patch tested?