[#12795] improvement(infra): Enable automatic GitHub Copilot code review - #12796
Merged
jerryshao merged 4 commits intoSep 2, 2026
Merged
Conversation
…de review Co-authored-by: Cursor <cursoragent@cursor.com>
…requiring it Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
nevzheng
marked this pull request as ready for review
September 1, 2026 15:33
nevzheng
force-pushed
the
improvement/enable-copilot-code-review
branch
from
September 1, 2026 15:35
6e5bba0 to
abec629
Compare
…k authors to add Copilot Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
Updating the proposal: Nevin |
Code Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable automatic GitHub Copilot review on non-draft pull requests targeting
main, and document that people should add Copilot. That is recommended, not required..asf.yamladds the ASF convenience block:enabled: true— create theCopilot Code Reviewruleset on the default branchreview_drafts: false— skip drafts; first auto-review when marked readyreview_on_push: false— do not re-review on later pushes; add Copilot by hand after updatesCONTRIBUTING.mdasks authors and reviewers to add Copilot, and to add it again after later pushes. Copilot is a first pass, not a gate..github/copilot-instructions.mdis unchanged.The full contract (what this does and does not do, billing, capabilities, limitations) is in #12795.
Why are the changes needed?
Copilot can already review when someone requests it. Automatic first-pass review needs the ASF
.asf.yamlruleset. Iceberg, Arrow, and other ASF projects already run this.Fix: #12795
Does this PR introduce any user-facing change?
No runtime, API, or property-key change. After merge, authors with Copilot code-review access can get an automatic first pass when the PR is marked ready. Later pushes do not re-review unless someone adds Copilot. Waiting for Copilot is recommended, not required. Required human approval stays 1.
How was this patch tested?
.asf.yamlas YAML (ruby -ryaml)git diff --checkpassedNevin
Sent from my 🤖 (Cursor)