Skip to content

[#12795] improvement(infra): Enable automatic GitHub Copilot code review - #12796

Merged
jerryshao merged 4 commits into
apache:mainfrom
nevzheng:improvement/enable-copilot-code-review
Sep 2, 2026
Merged

[#12795] improvement(infra): Enable automatic GitHub Copilot code review#12796
jerryshao merged 4 commits into
apache:mainfrom
nevzheng:improvement/enable-copilot-code-review

Conversation

@nevzheng

@nevzheng nevzheng commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

What changes were proposed in this pull request?

Enable automatic GitHub Copilot review on non-draft pull requests targeting main, and document that people should add Copilot. That is recommended, not required.

.asf.yaml adds the ASF convenience block:

  • enabled: true — create the Copilot Code Review ruleset on the default branch
  • review_drafts: false — skip drafts; first auto-review when marked ready
  • review_on_push: false — do not re-review on later pushes; add Copilot by hand after updates

CONTRIBUTING.md asks authors and reviewers to add Copilot, and to add it again after later pushes. Copilot is a first pass, not a gate. .github/copilot-instructions.md is unchanged.

The full contract (what this does and does not do, billing, capabilities, limitations) is in #12795.

Why are the changes needed?

Copilot can already review when someone requests it. Automatic first-pass review needs the ASF .asf.yaml ruleset. Iceberg, Arrow, and other ASF projects already run this.

Fix: #12795

Does this PR introduce any user-facing change?

No runtime, API, or property-key change. After merge, authors with Copilot code-review access can get an automatic first pass when the PR is marked ready. Later pushes do not re-review unless someone adds Copilot. Waiting for Copilot is recommended, not required. Required human approval stays 1.

How was this patch tested?

  • Parsed .asf.yaml as YAML (ruby -ryaml)
  • git diff --check passed
  • Automatic Copilot review can only be confirmed after merge, when ASF Infra applies the ruleset

Nevin
Sent from my 🤖 (Cursor)

@nevzheng
nevzheng requested review from jerryshao and roryqi September 1, 2026 14:59
@nevzheng nevzheng self-assigned this Sep 1, 2026
nevzheng and others added 3 commits September 1, 2026 08:33
…de review

Co-authored-by: Cursor <cursoragent@cursor.com>
…requiring it

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@nevzheng
nevzheng marked this pull request as ready for review September 1, 2026 15:33
@nevzheng
nevzheng force-pushed the improvement/enable-copilot-code-review branch from 6e5bba0 to abec629 Compare September 1, 2026 15:35
…k authors to add Copilot

Co-authored-by: Cursor <cursoragent@cursor.com>
@nevzheng

nevzheng commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator Author

Updating the proposal: review_on_push: false so Copilot auto-reviews once when the PR is marked ready, not on every push. CONTRIBUTING now asks people to add Copilot (and to add it again after later pushes). Copilot-before-human stays recommended, not required.

Nevin
Sent from my 🤖 (Cursor)

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

Code Coverage Report

Overall Project 68.91% 🟢
Files changed No Java source files changed -

Module Coverage
aliyun 19.74% 🔴
api 51.72% 🟢
authorization-common 85.96% 🟢
authorization-ranger 4.38% 🔴
aws 53.54% 🟢
azure 32.1% 🔴
catalog-common 19.1% 🔴
catalog-fileset 80.3% 🟢
catalog-glue 69.24% 🟢
catalog-hive 82.96% 🟢
catalog-jdbc-common 45.69% 🟢
catalog-jdbc-doris 82.69% 🟢
catalog-jdbc-mysql 79.33% 🟢
catalog-jdbc-postgresql 83.39% 🟢
catalog-jdbc-starrocks 79.16% 🟢
catalog-kafka 76.99% 🟢
catalog-lakehouse-generic 60.55% 🟢
catalog-lakehouse-hudi 79.1% 🟢
catalog-lakehouse-iceberg 85.86% 🟢
catalog-lakehouse-paimon 84.26% 🟢
catalog-model 77.99% 🟢
cli 44.48% 🟢
client-java 77.49% 🟢
common 55.96% 🟢
core 83.87% 🟢
filesystem-hadoop3 76.45% 🟢
flink 0.0% 🔴
flink-common 52.1% 🟢
flink-runtime 0.0% 🔴
gcp 32.2% 🔴
hadoop-auth 68.0% 🟢
hadoop-common 17.84% 🔴
hive-metastore-common 53.4% 🟢
iceberg-aliyun-bundle 0.0% 🔴
iceberg-common 64.75% 🟢
iceberg-rest-server 75.89% 🟢
idp-basic 85.98% 🟢
integration-test-common 0.0% 🔴
jobs 62.92% 🟢
lance-common 32.63% 🔴
lance-rest-server 65.46% 🟢
lineage 53.02% 🟢
optimizer 83.24% 🟢
optimizer-api 21.95% 🔴
server 88.33% 🟢
server-common 80.5% 🟢
spark 28.57% 🔴
spark-common 48.92% 🟢
tencent 81.78% 🟢
trino-connector 51.26% 🟢

@bharos bharos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerryshao
jerryshao merged commit ca33d31 into apache:main Sep 2, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] Enable automatic GitHub Copilot code review on pull requests

3 participants