[Cherry-pick to branch-1.3] [#12685] fix(core): Fix built-in policy supportedObjectTypes validation and error message (#12686) - #12882
Merged
Conversation
…on and error message (#12686) ## What changes were proposed in this pull request? Fix the validation of `supportedObjectTypes` when updating built-in policies. `PolicyManager.updatePolicyEntity()` currently uses `Sets.difference(oldTypes, newTypes).isEmpty()`, which only detects removed object types. When the updated set contains additional object types, the validation incorrectly passes. This change: - validates that the old and new supported object type sets are exactly equal; - fixes the validation error message by supplying the expected and actual sets; - adds a regression test covering attempted supported object type changes for a built-in policy. ## Why are the changes needed? Built-in policies must not change their supported metadata object types during an update. The previous asymmetric set comparison did not enforce this invariant for additions. Fixes #12685
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick Information:
branch-1.3