[Cherry-pick to branch-1.3] [#12885] fix(audit): Include role names in role assignment logs (#12886) - #12898
Merged
Merged
Conversation
### What changes were proposed in this pull request? Add the affected role names to the audit `customInfo` for: - `GRANT_USER_ROLES` - `REVOKE_USER_ROLES` - `GRANT_GROUP_ROLES` - `REVOKE_GROUP_ROLES` Both successful and failed operations now record `roleNames`. A shared helper keeps the audit field formatting consistent. ### Why are the changes needed? Role assignment audit entries currently identify the user or group but omit the roles that were granted or revoked. This prevents access reviews from reconstructing which permissions were changed. Fix: #12885 ### Does this PR introduce _any_ user-facing change? Yes. Role assignment audit entries now include the affected roles in `customInfo`, for example: `{roleNames=reader,admin}` ### How was this patch tested? - `./gradlew :core:spotlessApply` - `./gradlew :core:test --tests org.apache.gravitino.listener.api.event.TestUserEvent --tests org.apache.gravitino.listener.api.event.TestGroupEvent --tests org.apache.gravitino.audit.v2.TestSimpleAuditLogV2`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick Information:
branch-1.3