Skip to content

[Cherry-pick to branch-1.3] [#12712] fix(trino-connector): Add integration test for TLS + OAuth2 credential vending (#12713) - #12908

Merged
jerryshao merged 3 commits into
branch-1.3from
cherry-pick-5027095c-to-branch-1.3
Sep 4, 2026
Merged

[Cherry-pick to branch-1.3] [#12712] fix(trino-connector): Add integration test for TLS + OAuth2 credential vending (#12713)#12908
jerryshao merged 3 commits into
branch-1.3from
cherry-pick-5027095c-to-branch-1.3

Conversation

@github-actions

@github-actions github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

Cherry-pick Information:

  • Original commit: 5027095
  • Target branch: branch-1.3
  • Status: ⚠️ Has conflicts - manual resolution required

…credential vending (#12713)

### What changes were proposed in this pull request?

Adds an integration test (`TrinoTlsOAuthCredentialVendingIT`) covering
the Trino connector's full secured path: HTTPS coordinator,
OAuth2-authenticated Gravitino client, and Iceberg REST OAuth2
credential vending together.

### Why are the changes needed?

This combination wasn't covered end-to-end by existing tests.

Fix: #12712

### Does this PR introduce any user-facing change?

No.

### How was this patch tested?

New integration test, not run locally (requires Docker).

---------

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
# Conflicts:
#	trino-connector/integration-test/build.gradle.kts
@github-actions github-actions Bot added cherry-pick Automatically opened cherry-pick PR cherry-pick-conflict Cherry-pick has conflicts; needs human resolution before merge labels Sep 4, 2026
@github-actions
github-actions Bot requested a review from jerryshao September 4, 2026 06:15
diqiu50 and others added 2 commits September 4, 2026 16:29
The cherry-pick commit f7d42b2 for #12712 left unresolved conflict
markers in build.gradle.kts instead of keeping both setupDependencies
task lines. branch-1.3 still has the trino-connector-435-439 module,
so both dependsOn lines are required.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018o5pS4bnbQycv3tFK22DSB
@diqiu50 diqiu50 changed the title [DO NOT MERGE] [Cherry-pick to branch-1.3] [#12712] fix(trino-connector): Add integration test for TLS + OAuth2 credential vending (#12713) [Cherry-pick to branch-1.3] [#12712] fix(trino-connector): Add integration test for TLS + OAuth2 credential vending (#12713) Sep 4, 2026
@diqiu50 diqiu50 self-assigned this Sep 4, 2026
@diqiu50 diqiu50 removed the cherry-pick-conflict Cherry-pick has conflicts; needs human resolution before merge label Sep 4, 2026
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Author

Code Coverage Report

Overall Project 68.67% -0.17% 🟢
Files changed 59.66% 🔴

Module Coverage
aliyun 19.74% 🔴
api 47.62% 🟢
authorization-common 85.96% 🟢
aws 53.54% 🟢
azure 32.1% 🔴
catalog-common 10.4% 🔴
catalog-fileset 80.51% 🟢
catalog-glue 69.24% 🟢
catalog-hive 79.42% 🟢
catalog-jdbc-clickhouse 84.7% 🟢
catalog-jdbc-common 45.47% 🟢
catalog-jdbc-doris 82.61% 🟢
catalog-jdbc-hologres 54.03% 🟢
catalog-jdbc-mysql 79.33% 🟢
catalog-jdbc-oceanbase 78.6% 🟢
catalog-jdbc-postgresql 83.39% 🟢
catalog-jdbc-starrocks 79.16% 🟢
catalog-kafka 77.27% 🟢
catalog-lakehouse-generic 59.35% 🟢
catalog-lakehouse-hudi 79.1% 🟢
catalog-lakehouse-iceberg 85.94% 🟢
catalog-lakehouse-paimon 82.17% 🟢
catalog-model 77.99% 🟢
cli 44.51% 🟢
client-java 78.31% 🟢
common 50.74% 🟢
core 82.97% +0.06% 🟢
filesystem-hadoop3 77.3% 🟢
flink 0.0% 🔴
flink-common 49.22% 🟢
flink-runtime 0.0% 🔴
gcp 32.2% 🔴
hadoop-common 15.43% 🔴
hive-metastore-common 53.77% 🟢
iceberg-aliyun-bundle 0.0% 🔴
iceberg-common 58.18% 🟢
iceberg-rest-server 73.97% 🟢
idp-basic 86.02% 🟢
integration-test-common 0.0% 🔴
jobs 66.17% 🟢
lance-common 24.42% 🔴
lance-rest-server 60.13% 🟢
lineage 53.02% 🟢
optimizer 82.95% 🟢
optimizer-api 21.95% 🔴
server 88.55% 🟢
server-common 76.28% 🟢
spark 28.57% 🔴
spark-common 41.66% -3.04% 🟢
trino-connector 51.18% +2.07% 🟢
Files
Module File Coverage
core FunctionMetaService.java 100.0% 🟢
ViewMetaService.java 100.0% 🟢
PolicyManager.java 81.09% 🟢
PolicyMetadataObjectRelBaseSQLProvider.java 76.92% 🟢
PolicyMetadataObjectRelPostgreSQLProvider.java 70.0% 🟢
spark-common IcebergPropertiesConverter.java 86.36% 🟢
GravitinoCatalogManager.java 53.12% 🔴
GravitinoDriverPlugin.java 15.15% 🔴
GravitinoSparkConfig.java 0.0% 🔴
GravitinoIcebergCatalog.java 0.0% 🔴
IcebergPropertiesConstants.java 0.0% 🔴
trino-connector GravitinoSystemTable.java 100.0% 🟢
GravitinoConfig.java 88.34% 🟢
CatalogRegister.java 68.89% 🟢
GravitinoConnectorFactory.java 68.75% 🟢
GravitinoSystemTableFactory.java 63.64% 🟢
DropCatalogStoredProcedure.java 53.85% 🔴
CatalogConnectorManager.java 49.73% 🔴
GravitinoSystemConnector.java 30.23% 🔴
GravitinoSystemTableCatalog.java 22.5% 🔴
CreateCatalogStoredProcedure.java 12.82% 🔴
AlterCatalogStoredProcedure.java 9.26% 🔴
GravitinoSystemConnectorMetadata.java 0.0% 🔴

@jerryshao
jerryshao merged commit 7c77716 into branch-1.3 Sep 4, 2026
35 checks passed
@jerryshao
jerryshao deleted the cherry-pick-5027095c-to-branch-1.3 branch September 4, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick Automatically opened cherry-pick PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants