[#5626] feat (gvfs-fuse): Set up a submodule project for the Gvfs-fuse by diqiu50 · Pull Request #5627 · apache/gravitino

diqiu50 · 2024-11-20T07:56:35Z

What changes were proposed in this pull request?

Set up a submodule project for the Gvfs-fuse, layout the rust module environment for gvfs-fuse

Why are the changes needed?

Fix: #5626

Does this PR introduce any user-facing change?

No

How was this patch tested?

No

settings.gradle.kts

xunliu · 2024-11-20T10:05:20Z

clients/gvfs-fuse/build.gradle.kts

I think you need use a Gradle for Rust plugin to compile this module, just like client-python.
maybe we can use the Gradle Rust plugin to install Rust compile tools in the temp dir.

https://plugins.gradle.org/search?term=rust

I tried some rust plugins. I can't found a good one

FANNG1 · 2024-11-20T12:00:51Z

suggest to do some auto check like cargo-machete cargo-sort cargo clippy cargo fmt, you could refer https://github.com/apache/iceberg-rust/blob/main/.github/workflows/ci.yml#L55-L68

clients/gvfs-fuse/check_rust_env.sh

tengqm · 2024-11-21T06:10:55Z

clients/gvfs-fuse/check_rust_env.sh

+        exit 1
+    fi
+
+    export PATH="$HOME/.cargo/bin:$PATH"


What if I run this script several times?

If successful, the install branch can be skipped

I'd suggest we don't do this in the script.
Most of the software installer scripts avoid doing this.
It may and may not be desirable for the user.

clients/gvfs-fuse/check_rust_env.sh

clients/gvfs-fuse/build.gradle.kts

tengqm · 2024-11-21T07:33:31Z

clients/filesystem-fuse/check_rust_env.sh

+if ! command -v cargo &> /dev/null; then
+    echo "Rust is not installed. Installing Rust..."
+
+    if command -v curl &> /dev/null; then
+        curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
+    elif command -v wget &> /dev/null; then
+        wget -qO- https://sh.rustup.rs | sh -s -- -y
+    else
+        echo "Error: Neither curl nor wget is available. Please install one of them to proceed."
+        exit 1
+    fi
+
+    export PATH="$HOME/.cargo/bin:$PATH"
+    if command -v cargo &> /dev/null; then
+        echo "Rust has been installed successfully."
+    else
+        echo "Error: Rust installation failed. Please check your setup."
+        exit 1
+    fi
+else
+    echo "Rust is already installed: $(cargo --version)"
+fi


I'd do this to 1) return early if possible 2) save some of the nested if- tests.

if command -v cargo &> /dev/null; then echo "Rust is already installed: $(cargo --version)" exit 0 fi echo "Rust is not installed. Installing Rust..." # the rest of the install and check # ... if ! command -v cargo &> /dev/null; then echo "Error: Rust installation failed. Please check your setup." exit 1 fi echo "Rust has been installed successfully." exit 0

The cargo command does not run after running the rust installation command. Unless you set the PATH environment variable or restart the bash session.

well ... we are assuming that cargo is installed in a specific directory, i.e. $HOME/.cargo/bin, any way...
The only difference is that we manually invoke the binary (with full path) or let the "polluted" shell to find it. Right?

Yes, the cargo install script will add logic to modify the PATH inn the .profile. If we restart the shell session, it will automatically add this environment variable.
Is modifying the PATH not allowed?

clients/filesystem-fuse/Cargo.toml

clients/filesystem-fuse/check_rust_env.sh

jerryshao · 2024-11-21T07:36:55Z

@FANNG1 can you please help to review?

clients/filesystem-fuse/Cargo.toml

jerryshao · 2024-11-21T13:06:31Z

clients/filesystem-fuse/Cargo.toml

+[package]
+name = "filesystem-fuse"
+version = "0.8.0-incubating-SNAPSHOT"
+edition = "2021"


What is the usage of this "edition", shall we remove this?

The version specify the minimum Rust compiler version required for this project.

clients/filesystem-fuse/check_rust_env.sh

FANNG1 · 2024-11-21T13:29:43Z

suggest adding basic check for code style and common errors in ci

        cargo  fmt --all -- --check
        cargo  clippy --all-targets --all-features --workspace -- -D warnings

clients/filesystem-fuse/Cargo.toml

FANNG1 · 2024-11-22T02:18:48Z

clients/filesystem-fuse/Cargo.toml

+path = "src/main.rs"
+
+[dependencies]
+fuse3 = { version = "0.8.1", "features" = ["tokio-runtime", "unprivileged"] }


There are many fuse implement in RUST, why you choose fuse3?

seems fuser is more popular

Yes, fuser is more popular, but FUSE3 is used by OpenDAL. We need to decide which one to use soon

clients/filesystem-fuse/Cargo.toml

jerryshao · 2024-11-22T12:05:37Z

@FANNG1 can you please help to review again? If there's no blocking issue, I think we can improve the building command in the following PRs, what do you think?

FANNG1 · 2024-11-23T14:22:48Z

@FANNG1 can you please help to review again? If there's no blocking issue, I think we can improve the building command in the following PRs, what do you think?

Seems there're some basic issues to be addressed,

Whether to build fuse-rust by default, I prefer not, because it's difficult for most persons.
To enable code style and clippy check, I'm ok to add the check in this or next PR.
Which rust fuse lib should we choose, if we doesn't have an answer for now, I prefer to remove the current fuse depedences.

diqiu50 · 2024-11-25T03:59:02Z

@FANNG1
I have made modifications. The -Penable_gvfs_fuse parameter needs to be added to build gvfs_fuse, and it will not automatically install Rust."

clients/filesystem-fuse/Cargo.toml

clients/filesystem-fuse/check_rust_env.sh

FANNG1 · 2024-11-25T06:36:17Z

LGTM, except minor comments

clients/filesystem-fuse/build.gradle.kts

FANNG1 · 2024-11-26T02:21:08Z

clients/filesystem-fuse/build.gradle.kts

+    """
+          set -e
+          echo "Checking the code format"
+          cargo fmt --all -- --check


Normally, cargo fmt and clippy aren't combined with build. do you plan to separate it ?

What are the benefits of splitting it up?

I could do the check seperately without building the code.

settings.gradle.kts

@LauraXia123

Bumps [axios](https://github.com/axios/axios) from 1.10.0 to 1.12.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/releases">axios's releases</a>.</em></p> <blockquote> <h2>Release v1.12.0</h2> <h2>Release notes:</h2> <h3>Bug Fixes</h3> <ul> <li>adding build artifacts (<a href="https://github.com/axios/axios/commit/9ec86de257bfa33856571036279169f385ed92bd">9ec86de</a>)</li> <li>dont add dist on release (<a href="https://github.com/axios/axios/commit/a2edc3606a4f775d868a67bb3461ff18ce7ecd11">a2edc36</a>)</li> <li><strong>fetch-adapter:</strong> set correct Content-Type for Node FormData (<a href="https://redirect.github.com/axios/axios/issues/6998">#6998</a>) (<a href="https://github.com/axios/axios/commit/a9f47afbf3224d2ca987dbd8188789c7ea853c5d">a9f47af</a>)</li> <li><strong>node:</strong> enforce maxContentLength for data: URLs (<a href="https://redirect.github.com/axios/axios/issues/7011">#7011</a>) (<a href="https://github.com/axios/axios/commit/945435fc51467303768202250debb8d4ae892593">945435f</a>)</li> <li>package exports (<a href="https://redirect.github.com/axios/axios/issues/5627">#5627</a>) (<a href="https://github.com/axios/axios/commit/aa78ac23fc9036163308c0f6bd2bb885e7af3f36">aa78ac2</a>)</li> <li><strong>params:</strong> removing '[' and ']' from URL encode exclude characters (<a href="https://redirect.github.com/axios/axios/issues/3316">#3316</a>) (<a href="https://redirect.github.com/axios/axios/issues/5715">#5715</a>) (<a href="https://github.com/axios/axios/commit/6d84189349c43b1dcdd977b522610660cc4c7042">6d84189</a>)</li> <li>release pr run (<a href="https://github.com/axios/axios/commit/fd7f404488b2c4f238c2fbe635b58026a634bfd2">fd7f404</a>)</li> <li><strong>types:</strong> change the type guard on isCancel (<a href="https://redirect.github.com/axios/axios/issues/5595">#5595</a>) (<a href="https://github.com/axios/axios/commit/0dbb7fd4f61dc568498cd13a681fa7f907d6ec7e">0dbb7fd</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>adapter:</strong> surface low‑level network error details; attach original error via cause (<a href="https://redirect.github.com/axios/axios/issues/6982">#6982</a>) (<a href="https://github.com/axios/axios/commit/78b290c57c978ed2ab420b90d97350231c9e5d74">78b290c</a>)</li> <li><strong>fetch:</strong> add fetch, Request, Response env config variables for the adapter; (<a href="https://redirect.github.com/axios/axios/issues/7003">#7003</a>) (<a href="https://github.com/axios/axios/commit/c959ff29013a3bc90cde3ac7ea2d9a3f9c08974b">c959ff2</a>)</li> <li>support reviver on JSON.parse (<a href="https://redirect.github.com/axios/axios/issues/5926">#5926</a>) (<a href="https://github.com/axios/axios/commit/2a9763426e43d996fd60d01afe63fa6e1f5b4fca">2a97634</a>), closes <a href="https://redirect.github.com/axios/axios/issues/5924">#5924</a></li> <li><strong>types:</strong> extend AxiosResponse interface to include custom headers type (<a href="https://redirect.github.com/axios/axios/issues/6782">#6782</a>) (<a href="https://github.com/axios/axios/commit/7960d34eded2de66ffd30b4687f8da0e46c4903e">7960d34</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li> <a href="https://github.com/WillianAgostini" title="+132/-16760 ([#7002](axios/axios#7002) [#5926](axios/axios#5926) [#6782](axios/axios#6782) )">Willian Agostini</a></li> <li> <a href="https://github.com/DigitalBrainJS" title="+4263/-293 ([#7006](axios/axios#7006) [#7003](axios/axios#7003) )">Dmitriy Mozgovoy</a></li> <li> <a href="https://github.com/mkhani01" title="+111/-15 ([#6982](axios/axios#6982) )">khani</a></li> <li> <a href="https://github.com/AmeerAssadi" title="+123/-0 ([#7011](axios/axios#7011) )">Ameer Assadi</a></li> <li> <a href="https://github.com/emiedonmokumo" title="+55/-35 ([#6998](axios/axios#6998) )">Emiedonmokumo Dick-Boro</a></li> <li> <a href="https://github.com/opsysdebug" title="+8/-8 ([#6980](axios/axios#6980) )">Zeroday BYTE</a></li> <li> <a href="https://github.com/jasonsaayman" title="+7/-7 ([#6985](axios/axios#6985) [#6985](axios/axios#6985) )">Jason Saayman</a></li> <li> <a href="https://github.com/HealGaren" title="+5/-7 ([#5715](axios/axios#5715) )">최예찬</a></li> <li> <a href="https://github.com/gligorkot" title="+3/-1 ([#5627](axios/axios#5627) )">Gligor Kotushevski</a></li> <li> <a href="https://github.com/adimit" title="+2/-1 ([#5595](axios/axios#5595) )">Aleksandar Dimitrov</a></li> </ul> <h2>Release v1.11.0</h2> <h2>Release notes:</h2> <h3>Bug Fixes</h3> <ul> <li>form-data npm pakcage (<a href="https://redirect.github.com/axios/axios/issues/6970">#6970</a>) (<a href="https://github.com/axios/axios/commit/e72c193722530db538b19e5ddaaa4544d226b253">e72c193</a>)</li> <li>prevent RangeError when using large Buffers (<a href="https://redirect.github.com/axios/axios/issues/6961">#6961</a>) (<a href="https://github.com/axios/axios/commit/a2214ca1bc60540baf2c80573cea3a0ff91ba9d1">a2214ca</a>)</li> <li><strong>types:</strong> resolve type discrepancies between ESM and CJS TypeScript declaration files (<a href="https://redirect.github.com/axios/axios/issues/6956">#6956</a>) (<a href="https://github.com/axios/axios/commit/8517aa16f8d082fc1d5309c642220fa736159110">8517aa1</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li> <a href="https://github.com/izzygld" title="+186/-93 ([#6970](axios/axios#6970) )">izzy goldman</a></li> <li> <a href="https://github.com/manishsahanidev" title="+70/-0 ([#6961](axios/axios#6961) )">Manish Sahani</a></li> <li> <a href="https://github.com/noritaka1166" title="+12/-10 ([#6938](axios/axios#6938) [#6939](axios/axios#6939) )">Noritaka Kobayashi</a></li> <li> <a href="https://github.com/jrnail23" title="+13/-2 ([#6956](axios/axios#6956) )">James Nail</a></li> <li> <a href="https://github.com/Tejaswi1305" title="+1/-1 ([#6894](axios/axios#6894) )">Tejaswi1305</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/blob/v1.x/CHANGELOG.md">axios's changelog</a>.</em></p> <blockquote> <h1><a href="https://github.com/axios/axios/compare/v1.11.0...v1.12.0">1.12.0</a> (2025-09-11)</h1> <h3>Bug Fixes</h3> <ul> <li>adding build artifacts (<a href="https://github.com/axios/axios/commit/9ec86de257bfa33856571036279169f385ed92bd">9ec86de</a>)</li> <li>dont add dist on release (<a href="https://github.com/axios/axios/commit/a2edc3606a4f775d868a67bb3461ff18ce7ecd11">a2edc36</a>)</li> <li><strong>fetch-adapter:</strong> set correct Content-Type for Node FormData (<a href="https://redirect.github.com/axios/axios/issues/6998">#6998</a>) (<a href="https://github.com/axios/axios/commit/a9f47afbf3224d2ca987dbd8188789c7ea853c5d">a9f47af</a>)</li> <li><strong>node:</strong> enforce maxContentLength for data: URLs (<a href="https://redirect.github.com/axios/axios/issues/7011">#7011</a>) (<a href="https://github.com/axios/axios/commit/945435fc51467303768202250debb8d4ae892593">945435f</a>)</li> <li>package exports (<a href="https://redirect.github.com/axios/axios/issues/5627">#5627</a>) (<a href="https://github.com/axios/axios/commit/aa78ac23fc9036163308c0f6bd2bb885e7af3f36">aa78ac2</a>)</li> <li><strong>params:</strong> removing '[' and ']' from URL encode exclude characters (<a href="https://redirect.github.com/axios/axios/issues/3316">#3316</a>) (<a href="https://redirect.github.com/axios/axios/issues/5715">#5715</a>) (<a href="https://github.com/axios/axios/commit/6d84189349c43b1dcdd977b522610660cc4c7042">6d84189</a>)</li> <li>release pr run (<a href="https://github.com/axios/axios/commit/fd7f404488b2c4f238c2fbe635b58026a634bfd2">fd7f404</a>)</li> <li><strong>types:</strong> change the type guard on isCancel (<a href="https://redirect.github.com/axios/axios/issues/5595">#5595</a>) (<a href="https://github.com/axios/axios/commit/0dbb7fd4f61dc568498cd13a681fa7f907d6ec7e">0dbb7fd</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>adapter:</strong> surface low‑level network error details; attach original error via cause (<a href="https://redirect.github.com/axios/axios/issues/6982">#6982</a>) (<a href="https://github.com/axios/axios/commit/78b290c57c978ed2ab420b90d97350231c9e5d74">78b290c</a>)</li> <li><strong>fetch:</strong> add fetch, Request, Response env config variables for the adapter; (<a href="https://redirect.github.com/axios/axios/issues/7003">#7003</a>) (<a href="https://github.com/axios/axios/commit/c959ff29013a3bc90cde3ac7ea2d9a3f9c08974b">c959ff2</a>)</li> <li>support reviver on JSON.parse (<a href="https://redirect.github.com/axios/axios/issues/5926">#5926</a>) (<a href="https://github.com/axios/axios/commit/2a9763426e43d996fd60d01afe63fa6e1f5b4fca">2a97634</a>), closes <a href="https://redirect.github.com/axios/axios/issues/5924">#5924</a></li> <li><strong>types:</strong> extend AxiosResponse interface to include custom headers type (<a href="https://redirect.github.com/axios/axios/issues/6782">#6782</a>) (<a href="https://github.com/axios/axios/commit/7960d34eded2de66ffd30b4687f8da0e46c4903e">7960d34</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li> <a href="https://github.com/WillianAgostini" title="+132/-16760 ([#7002](axios/axios#7002) [#5926](axios/axios#5926) [#6782](axios/axios#6782) )">Willian Agostini</a></li> <li> <a href="https://github.com/DigitalBrainJS" title="+4263/-293 ([#7006](axios/axios#7006) [#7003](axios/axios#7003) )">Dmitriy Mozgovoy</a></li> <li> <a href="https://github.com/mkhani01" title="+111/-15 ([#6982](axios/axios#6982) )">khani</a></li> <li> <a href="https://github.com/AmeerAssadi" title="+123/-0 ([#7011](axios/axios#7011) )">Ameer Assadi</a></li> <li> <a href="https://github.com/emiedonmokumo" title="+55/-35 ([#6998](axios/axios#6998) )">Emiedonmokumo Dick-Boro</a></li> <li> <a href="https://github.com/opsysdebug" title="+8/-8 ([#6980](axios/axios#6980) )">Zeroday BYTE</a></li> <li> <a href="https://github.com/jasonsaayman" title="+7/-7 ([#6985](axios/axios#6985) [#6985](axios/axios#6985) )">Jason Saayman</a></li> <li> <a href="https://github.com/HealGaren" title="+5/-7 ([#5715](axios/axios#5715) )">최예찬</a></li> <li> <a href="https://github.com/gligorkot" title="+3/-1 ([#5627](axios/axios#5627) )">Gligor Kotushevski</a></li> <li> <a href="https://github.com/adimit" title="+2/-1 ([#5595](axios/axios#5595) )">Aleksandar Dimitrov</a></li> </ul> <h1><a href="https://github.com/axios/axios/compare/v1.10.0...v1.11.0">1.11.0</a> (2025-07-22)</h1> <h3>Bug Fixes</h3> <ul> <li>form-data npm pakcage (<a href="https://redirect.github.com/axios/axios/issues/6970">#6970</a>) (<a href="https://github.com/axios/axios/commit/e72c193722530db538b19e5ddaaa4544d226b253">e72c193</a>)</li> <li>prevent RangeError when using large Buffers (<a href="https://redirect.github.com/axios/axios/issues/6961">#6961</a>) (<a href="https://github.com/axios/axios/commit/a2214ca1bc60540baf2c80573cea3a0ff91ba9d1">a2214ca</a>)</li> <li><strong>types:</strong> resolve type discrepancies between ESM and CJS TypeScript declaration files (<a href="https://redirect.github.com/axios/axios/issues/6956">#6956</a>) (<a href="https://github.com/axios/axios/commit/8517aa16f8d082fc1d5309c642220fa736159110">8517aa1</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li> <a href="https://github.com/izzygld" title="+186/-93 ([#6970](axios/axios#6970) )">izzy goldman</a></li> <li> <a href="https://github.com/manishsahanidev" title="+70/-0 ([#6961](axios/axios#6961) )">Manish Sahani</a></li> <li> <a href="https://github.com/noritaka1166" title="+12/-10 ([#6938](axios/axios#6938) [#6939](axios/axios#6939) )">Noritaka Kobayashi</a></li> <li> <a href="https://github.com/jrnail23" title="+13/-2 ([#6956](axios/axios#6956) )">James Nail</a></li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/axios/axios/commit/0d8ad6e1de0f5339e02bc262d6f0df4936974120"><code>0d8ad6e</code></a> chore(release): v1.12.0 (<a href="https://redirect.github.com/axios/axios/issues/7013">#7013</a>)</li> <li><a href="https://github.com/axios/axios/commit/fd7f404488b2c4f238c2fbe635b58026a634bfd2"><code>fd7f404</code></a> fix: release pr run</li> <li><a href="https://github.com/axios/axios/commit/a2edc3606a4f775d868a67bb3461ff18ce7ecd11"><code>a2edc36</code></a> fix: dont add dist on release</li> <li><a href="https://github.com/axios/axios/commit/9ec86de257bfa33856571036279169f385ed92bd"><code>9ec86de</code></a> fix: adding build artifacts</li> <li><a href="https://github.com/axios/axios/commit/945435fc51467303768202250debb8d4ae892593"><code>945435f</code></a> fix(node): enforce maxContentLength for data: URLs (<a href="https://redirect.github.com/axios/axios/issues/7011">#7011</a>)</li> <li><a href="https://github.com/axios/axios/commit/28e5e3016d6ed0b3ec489427e4ec00133f45ddc2"><code>28e5e30</code></a> chore(sponsor): update sponsor block (<a href="https://redirect.github.com/axios/axios/issues/7005">#7005</a>)</li> <li><a href="https://github.com/axios/axios/commit/d03f245a40ec016b190748a865cce9fe3815c903"><code>d03f245</code></a> chore(CI): fixed release info script to use npm registry instead of git as fi...</li> <li><a href="https://github.com/axios/axios/commit/a0bc91137950f36a1f6b0a2a60d11fd7f245ff0e"><code>a0bc911</code></a> chore: removing dist files from src (<a href="https://redirect.github.com/axios/axios/issues/7002">#7002</a>)</li> <li><a href="https://github.com/axios/axios/commit/c959ff29013a3bc90cde3ac7ea2d9a3f9c08974b"><code>c959ff2</code></a> feat(fetch): add fetch, Request, Response env config variables for the adapte...</li> <li><a href="https://github.com/axios/axios/commit/a9f47afbf3224d2ca987dbd8188789c7ea853c5d"><code>a9f47af</code></a> fix(fetch-adapter): set correct Content-Type for Node FormData (<a href="https://redirect.github.com/axios/axios/issues/6998">#6998</a>)</li> <li>Additional commits viewable in <a href="https://github.com/axios/axios/compare/v1.10.0...v1.12.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=axios&package-manager=npm_and_yarn&previous-version=1.10.0&new-version=1.12.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) Dependabot will merge this PR once CI passes on it, as requested by @LauraXia123. [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/gravitino/network/alerts). </details> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

layout gvfs-fuse project

ae2d5f6

diqiu50 force-pushed the gvfs-1 branch from 89c8f52 to ae2d5f6 Compare November 20, 2024 07:59

diqiu50 added 5 commits November 20, 2024 16:00

Update

5817280

Update

20ee836

Update

72c5f7b

Update

c34dd34

Update

6dce7e9

diqiu50 force-pushed the gvfs-1 branch from 6fc97bc to 08d609b Compare November 20, 2024 09:44

jerryshao reviewed Nov 20, 2024

View reviewed changes

settings.gradle.kts Outdated Show resolved Hide resolved

xunliu reviewed Nov 20, 2024

View reviewed changes

xunliu assigned diqiu50 Nov 20, 2024

yuqi1129 reviewed Nov 21, 2024

View reviewed changes

clients/gvfs-fuse/check_rust_env.sh Outdated Show resolved Hide resolved

tengqm reviewed Nov 21, 2024

View reviewed changes

diqiu50 added 2 commits November 21, 2024 15:12

Update

82b30d3

Update

46c4882

diqiu50 force-pushed the gvfs-1 branch from 08d609b to 46c4882 Compare November 21, 2024 07:17

tengqm reviewed Nov 21, 2024

View reviewed changes

jerryshao reviewed Nov 21, 2024

View reviewed changes

clients/filesystem-fuse/Cargo.toml Outdated Show resolved Hide resolved

jerryshao reviewed Nov 21, 2024

View reviewed changes

clients/filesystem-fuse/Cargo.toml Outdated Show resolved Hide resolved

jerryshao reviewed Nov 21, 2024

View reviewed changes

clients/filesystem-fuse/check_rust_env.sh Outdated Show resolved Hide resolved

jerryshao requested a review from FANNG1 November 21, 2024 07:36

Update for review

f2fbc1a

FANNG1 reviewed Nov 21, 2024

View reviewed changes

clients/filesystem-fuse/Cargo.toml Outdated Show resolved Hide resolved

jerryshao reviewed Nov 21, 2024

View reviewed changes

FANNG1 reviewed Nov 21, 2024

View reviewed changes

clients/filesystem-fuse/check_rust_env.sh Show resolved Hide resolved

FANNG1 reviewed Nov 21, 2024

View reviewed changes

clients/filesystem-fuse/Cargo.toml Show resolved Hide resolved

FANNG1 reviewed Nov 22, 2024

View reviewed changes

clients/filesystem-fuse/Cargo.toml Show resolved Hide resolved

Update

273d20e

Update

86d225a

diqiu50 requested a review from FANNG1 November 25, 2024 03:55

FANNG1 reviewed Nov 25, 2024

View reviewed changes

clients/filesystem-fuse/Cargo.toml Show resolved Hide resolved

clients/filesystem-fuse/check_rust_env.sh Show resolved Hide resolved

jerryshao reviewed Nov 25, 2024

View reviewed changes

clients/filesystem-fuse/build.gradle.kts Outdated Show resolved Hide resolved

diqiu50 added 4 commits November 25, 2024 19:20

Update

c7298e5

Update

784df21

Update

e7c2c51

Update comments

4b57527

FANNG1 reviewed Nov 26, 2024

View reviewed changes

diqiu50 added 5 commits November 26, 2024 11:02

Add ignore license

8d15ad3

Update

411f735

Update

e7eb3a2

Update

cf8debb

Update

97a717d

FANNG1 previously approved these changes Nov 26, 2024

View reviewed changes

jerryshao reviewed Nov 26, 2024

View reviewed changes

settings.gradle.kts Outdated Show resolved Hide resolved

Update

857a433

diqiu50 dismissed FANNG1’s stale review via 857a433 November 27, 2024 02:04

jerryshao approved these changes Nov 27, 2024

View reviewed changes

jerryshao merged commit bb3d868 into apache:main Nov 27, 2024

diqiu50 deleted the gvfs-1 branch January 3, 2025 10:32

Conversation

diqiu50 commented Nov 20, 2024

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Uh oh!

Uh oh!

xunliu Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FANNG1 commented Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

diqiu50 Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jerryshao commented Nov 21, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

FANNG1 commented Nov 21, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jerryshao commented Nov 22, 2024

Uh oh!

FANNG1 commented Nov 23, 2024

Uh oh!

diqiu50 commented Nov 25, 2024

Uh oh!

Uh oh!

Uh oh!

FANNG1 commented Nov 25, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

xunliu Nov 20, 2024 •

edited

Loading

FANNG1 commented Nov 20, 2024 •

edited

Loading

diqiu50 Nov 22, 2024 •

edited

Loading