Skip to content

last() method for LinkedList can be more efficient #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davydotcom wants to merge 1 commit into from
Closed

last() method for LinkedList can be more efficient #1456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9773,6 +9773,29 @@ public static <T> boolean push(List<T> self, T value) {
return true;
}


/**
* Returns the last item from the LinkedList.
* <pre class="groovyTestCase">
* def list = [3, 4, 2]
* assert list.last() == 2
* // check original is unaltered
* assert list == [3, 4, 2]
* </pre>
*
* @param self a List
* @return the last item from the List
* @throws NoSuchElementException if the list is empty and you try to access the last() item.
* @since 1.5.5
*/
public static <T> T last(LinkedList<T> self) {

if (self.isEmpty()) {
throw new NoSuchElementException("Cannot access last() element from an empty List");
}
return self.getLast();
}

/**
* Returns the last item from the List.
* <pre class="groovyTestCase">
Expand All @@ -9788,6 +9811,7 @@ public static <T> boolean push(List<T> self, T value) {
* @since 1.5.5
*/
public static <T> T last(List<T> self) {

if (self.isEmpty()) {
throw new NoSuchElementException("Cannot access last() element from an empty List");
}
Expand Down