Skip to content

GROOVY-12132: groovyc: print collected warnings on successful c…#2667

Merged
paulk-asert merged 1 commit into
apache:masterfrom
paulk-asert:groovy12132
Jul 11, 2026
Merged

GROOVY-12132: groovyc: print collected warnings on successful c…#2667
paulk-asert merged 1 commit into
apache:masterfrom
paulk-asert:groovy12132

Conversation

@paulk-asert

Copy link
Copy Markdown
Contributor

…ompilation (make -w effective)

@codecov-commenter

codecov-commenter commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.0663%. Comparing base (faee99b) to head (db56a64).
⚠️ Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
...n/java/org/codehaus/groovy/control/SourceUnit.java 33.3333% 2 Missing ⚠️
.../main/java/org/codehaus/groovy/ast/ModuleNode.java 0.0000% 1 Missing ⚠️
...in/java/org/codehaus/groovy/classgen/Verifier.java 66.6667% 0 Missing and 1 partial ⚠️
.../org/codehaus/groovy/tools/FileSystemCompiler.java 92.3077% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2667        +/-   ##
==================================================
+ Coverage     68.5706%   69.0663%   +0.4957%     
- Complexity      33808      34131       +323     
==================================================
  Files            1524       1536        +12     
  Lines          128141     128950       +809     
  Branches        23292      23386        +94     
==================================================
+ Hits            87867      89061      +1194     
+ Misses          32472      31911       -561     
- Partials         7802       7978       +176     
Files with missing lines Coverage Δ
...y/transform/TupleConstructorASTTransformation.java 85.7759% <100.0000%> (ø)
.../main/java/org/codehaus/groovy/ast/ModuleNode.java 88.0259% <0.0000%> (ø)
...in/java/org/codehaus/groovy/classgen/Verifier.java 90.0938% <66.6667%> (ø)
.../org/codehaus/groovy/tools/FileSystemCompiler.java 50.4808% <92.3077%> (+2.5216%) ⬆️
...n/java/org/codehaus/groovy/control/SourceUnit.java 66.6667% <33.3333%> (-1.6260%) ⬇️

... and 92 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@paulk-asert paulk-asert changed the title GroovyGROOVY-12132: groovyc: print collected warnings on successful c… GROOVY-12132: groovyc: print collected warnings on successful c… Jul 7, 2026
@paulk-asert paulk-asert requested a review from Copilot July 11, 2026 01:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR (GROOVY-12132) makes groovyc surface warnings collected during a successful compilation, aligning successful and failing compilation output so that -w is effective for command-line users.

Changes:

  • Print collected warnings to System.err after a successful FileSystemCompiler compilation.
  • Add tests that verify warnings are printed on success and that clean compiles remain silent.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/main/java/org/codehaus/groovy/tools/FileSystemCompiler.java Emits collected warnings after successful compilation via ErrorCollector.write(...).
src/test/groovy/org/codehaus/groovy/tools/FileSystemCompilerTest.java Adds coverage to assert warnings are shown on success and absent on clean compile.

Comment thread src/main/java/org/codehaus/groovy/tools/FileSystemCompiler.java Outdated
Comment thread src/test/groovy/org/codehaus/groovy/tools/FileSystemCompilerTest.java Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

@testlens-app

testlens-app Bot commented Jul 11, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: db56a64
▶️ Tests: 103505 executed
⚪️ Checks: 31/31 completed


Learn more about TestLens at testlens.app.

@paulk-asert paulk-asert merged commit fa8587a into apache:master Jul 11, 2026
32 checks passed
@paulk-asert paulk-asert deleted the groovy12132 branch July 11, 2026 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants