GROOVY-12132: groovyc: print collected warnings on successful c…#2667
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2667 +/- ##
==================================================
+ Coverage 68.5706% 69.0663% +0.4957%
- Complexity 33808 34131 +323
==================================================
Files 1524 1536 +12
Lines 128141 128950 +809
Branches 23292 23386 +94
==================================================
+ Hits 87867 89061 +1194
+ Misses 32472 31911 -561
- Partials 7802 7978 +176
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR (GROOVY-12132) makes groovyc surface warnings collected during a successful compilation, aligning successful and failing compilation output so that -w is effective for command-line users.
Changes:
- Print collected warnings to
System.errafter a successfulFileSystemCompilercompilation. - Add tests that verify warnings are printed on success and that clean compiles remain silent.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/java/org/codehaus/groovy/tools/FileSystemCompiler.java | Emits collected warnings after successful compilation via ErrorCollector.write(...). |
| src/test/groovy/org/codehaus/groovy/tools/FileSystemCompilerTest.java | Adds coverage to assert warnings are shown on success and absent on clean compile. |
…tion (make -w effective)
✅ All tests passed ✅🏷️ Commit: db56a64 Learn more about TestLens at testlens.app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ompilation (make -w effective)