wrap malformed json number decode in JsonException#2713
Closed
netliomax25-code wants to merge 1 commit into
Closed
wrap malformed json number decode in JsonException#2713netliomax25-code wants to merge 1 commit into
netliomax25-code wants to merge 1 commit into
Conversation
Contributor
|
Thanks! Merged as part of PR#2715 (GROOVY-12168) including tweaks to fix the build breakage and some consistency improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1e,1e+,1E, or-.is only rejected when the collected token reachesnew BigDecimal(...).NumberFormatExceptionin aJsonException(NumberValue.bigDecimalValue), but the default CHAR_BUFFER parser (CharScanner.parseJsonNumber) and the CHARACTER_SOURCE parser (JsonParserUsingCharacterSource.decodeNumber) let it propagate unwrapped, so an application guarding untrusted JSON withcatch (JsonException)sees a rawNumberFormatExceptioninstead.JsonException, matching the overlay parsers. Added a regression test that checks all four parser types.