reject lone low surrogate in StreamingMarkupWriter.write#2717
Open
netliomax25-code wants to merge 1 commit into
Open
reject lone low surrogate in StreamingMarkupWriter.write#2717netliomax25-code wants to merge 1 commit into
netliomax25-code wants to merge 1 commit into
Conversation
✅ All tests passed ✅🏷️ Commit: 6f69bc6 Learn more about TestLens at testlens.app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro: write a lone low surrogate (a
\uDC00-\uDFFFchar with no preceding high surrogate) through StreamingMarkupBuilder, e.g.new StreamingMarkupBuilder().bind { mkp.yield '\uDC00' }.Cause: the low-surrogate branch in
write(int)assumes a high surrogate was already buffered, so it readssurrogatePair.charAt(0)(the low surrogate itself) and emits a numeric character reference for an unrelated code point (\uDC00becomes𐀀) instead of failing.Fix: reject a low surrogate that is not preceded by a high surrogate, matching the existing rejection of a high surrogate not followed by a low one.