GROOVY-12173: Left-factor parser rules to reduce lookahead on hot parse paths#2720
Conversation
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 5b48b03 | Previous: c76e8dc | Ratio |
|---|---|---|---|
org.apache.groovy.bench.StaticMethodCallIndyBench.staticChain_groovyCS |
2518.853041605925 ops/ms |
1595.6378191431031 ops/ms |
1.58 |
org.apache.groovy.bench.StaticMethodCallIndyBench.staticChain_java |
2519.340726980061 ops/ms |
1595.5729626739744 ops/ms |
1.58 |
org.apache.groovy.bench.AryBench.java ( {"n":"1000"} ) |
0.08890228149919947 ms/op |
0.056632317821343335 ms/op |
1.57 |
org.apache.groovy.bench.CalibrationBench.memoryPointerChase |
1019.6160179175514 us/op |
507.29968992095434 us/op |
2.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2720 +/- ##
==================================================
- Coverage 69.2080% 69.2009% -0.0071%
+ Complexity 34495 34491 -4
==================================================
Files 1539 1539
Lines 129917 129913 -4
Branches 23670 23669 -1
==================================================
- Hits 89913 89901 -12
- Misses 31948 31952 +4
- Partials 8056 8060 +4
🚀 New features to boost your workflow:
|
JMH summary — classic (commit
|
| Group | Speedup | Calibrated | n |
|---|---|---|---|
| bench | 1.003 × | 0.997 × | 84 |
| core | 1.077 × | 1.109 × | 77 |
| grails | 1.018 × | 1.037 × | 80 |
Runner calibration (this run vs baseline hardware): bench 1.00× (26 rulers) · core-ag 0.94× (3 rulers) · core-hz 1.01× (3 rulers) · grails-ad 0.97× (3 rulers) · grails-ez 1.00× (3 rulers)
Baseline: dev/bench/jmh/<part>/classic/data.js on gh-pages, trailing 90 days. Daily dashboard · Per-suite raw data
JMH summary — indy (commit
|
| Group | Speedup | Calibrated | n |
|---|---|---|---|
| bench | 1.000 × | 1.002 × | 84 |
| core | 3.748 × | 3.947 × | 77 |
| grails | 2.777 × | 2.853 × | 80 |
Runner calibration (this run vs baseline hardware): bench 1.00× (26 rulers) · core-ag 0.99× (3 rulers) · core-hz 0.90× (3 rulers) · grails-ad 0.95× (3 rulers) · grails-ez 0.99× (3 rulers)
Baseline: dev/bench/jmh/<part>/indy/data.js on gh-pages, trailing 90 days. Daily dashboard · Per-suite raw data
a76dcfd to
6ab12c0
Compare
6ab12c0 to
5b48b03
Compare
|
✅ All tests passed ✅🏷️ Commit: 5b48b03 Learn more about TestLens at testlens.app. |



https://issues.apache.org/jira/browse/GROOVY-12173