GROOVY-12322: Inline the nls parser rule - #2848
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2848 +/- ##
==================================================
+ Coverage 70.7060% 70.7132% +0.0072%
- Complexity 36619 36648 +29
==================================================
Files 1571 1573 +2
Lines 134089 134146 +57
Branches 24729 24733 +4
==================================================
+ Hits 94809 94859 +50
Misses 30771 30771
- Partials 8509 8516 +7
🚀 New features to boost your workflow:
|
A shared nls : NL* rule has FOLLOW that includes NL via sep, so its star decision cannot be LL(1): every call pays adaptivePredict and an NlsContext allocation, including empty matches. Inlining NL* gives each call site its own star decision. GroovydocManager now reads NL terminals that used to be wrapped in NlsContext.
asf-gitbox-commits
force-pushed
the
GROOVY-12322
branch
from
August 30, 2026 14:54
431f1da to
922c146
Compare
|
✅ All tests passed ✅🏷️ Commit: 922c146 Learn more about TestLens at testlens.app/docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/GROOVY-12322