GROOVY-7611: java.util.Optional should evaluate to false if empty (Java8 VMPlugin) #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackdrag
approved these changes
May 21, 2017
Contributor
|
+1 |
Contributor
|
nice! |
Contributor
Author
|
Note to self, need to test GDK docs for new method on Optional and may need to add to Line 157 in 7ab4a71 |
Contributor
Author
|
This is missing a static compilation test, it looks like |
paulk-asert
approved these changes
May 23, 2017
Contributor
paulk-asert
left a comment
paulk-asert
left a comment
There was a problem hiding this comment.
I'd recommend changing @SInCE version from 2.5 to 2.5.0.
Also, agree that 2_5_X and 2_6_X branches would require tweaking in the build.
Also, note that there is some overlap with excluding */vm8/ files from tests in the test-vm8 subproject in GROOVY_2_6_X but the important thing there is the 1.8 sourceCompatibility.
asfgit
pushed a commit
that referenced
this pull request
May 27, 2017
asfgit
pushed a commit
that referenced
this pull request
May 27, 2017
jwagenleitner
added a commit
to jwagenleitner/groovy
that referenced
this pull request
May 27, 2017
Related to change for GROOVY-7611 (PR apache#545), JDK 8+ is required in order to compile all features.
asfgit
pushed a commit
that referenced
this pull request
May 28, 2017
Related to change for GROOVY-7611 (PR #545), JDK 8+ is required in order to compile all features.
asfgit
pushed a commit
that referenced
this pull request
May 28, 2017
Related to change for GROOVY-7611 (PR #545), JDK 8+ is required in order to compile all features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target for this would be
2_5_Xand above. For2_5_Xand2_6_Xit would require that the release process build with JDK 8 so would need to backport some of the build checks for Java version to those branches.