GUAC-1517: Maintain singleton instance of AudioContext. - #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A page only ever needs one instance of
AudioContext. If too manyAudioContextinstances are created, the browser will deny further creation, resulting in errors when Guacamole assumes such creation must succeed.This change adds a new
Guacamole.AudioContextFactorynamespace which contains a lazily-created singleton instance ofAudioContext. The instance is maintained and returned bygetAudioContext(), and can be overridden be manually assigning thesingletonproperty (if you already have your ownAudioContext, for example).