huowang #1021
Closed
huowang #1021
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
Author
|
Can I describe how to reproduce bugs and test modified patches? |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
Hi, thanks for the contribution, please follow the How to Contribute wiki https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-CreatingaGitHubpullrequest |
Author
|
ok
I'd love to, but I've been a little busy lately. I'll be out in a few days.
xxx_xxx@aliyun.com
From: Wei-Chiu Chuang
Date: 2019-07-26 23:57
To: apache/hadoop
CC: 苍井空的裸替; Author
Subject: Re: [apache/hadoop] huowang (#1021)
Hi, thanks for the contribution, please follow the How to Contribute wiki https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-CreatingaGitHubpullrequest
Specifically, file a ticket at Apache Hadoop JIRA, and prepend your git commit message with the JIRA id.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Member
|
Hi @arthas-171 |
Author
|
hi @aajisaka |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
…eption writing logic to DiagnosticsManager This PR * Removes ListGauge from everywhere. * Adds logic to LocalContainerRunner to write metadata, that is useful when combined with java's -XX:OnOutOfMemoryError=string option. * Adds DiagnosticsManager to publish error info to diagnostics stream instead of metrics reporter. * Adds logic to SamzaContainer to write the DiagnosticsManager while re-using the SystemProducer from the MetricsReporter. * Cleansup ContainerProcessManagerMetrics. * Adds DiagnosticsManager to ContainerProcessManager and the ClusterBasedJC Author: Ray Matharu <rmatharu@linkedin.com> Author: rmatharu <40646191+rmatharu@users.noreply.github.com> Reviewers: Prateek Maheshwari <pmaheshwari@apache.org> Closes apache#1021 from rmatharu/job-metadata
Contributor
|
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a problem when I converted edits files from XML to binary using the HDFS oev command
Usually this conversion operation will not be a problem, but my XML culture contains an OP_TRUNCATE operation node, in this case, the error is reported, the specific error is as follows. (sorry, I can only take a screenshot because the company environment does not allow copying code, the name of the file is not NameNode's default name because I backed up the edits file for testing).
The contents of the XML file are as follows
I found the error-reporting code and found that the blockFromXml method passed the entire data node instead of the subordinate BLOCK node. I think this was the reason. So I modified the code and recompiled it. Then I installed a single node Hadoop cluster and tested the HDFS oev command conversion file successfully. This is my first time to submit a patch. My English is not particularly good, I am not sure. Should the modified code be submitted in this way?
I hope I can contribute to the community.