Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Acceptance test fails at ACL checks:

[ {
  "type" : "USER",
  "name" : "testuser/scm@EXAMPLE.COM",
  "aclScope" : "ACCESS",
  "aclList" : [ "ALL" ]
}, {
  "type" : "GROUP",
  "name" : "root",
  "aclScope" : "ACCESS",
  "aclList" : [ "ALL" ]
}, {
  "type" : "GROUP",
  "name" : "superuser1",
  "aclScope" : "ACCESS",
  "aclList" : [ "ALL" ]
}, {
  "type" : "USER",
  "name" : "superuser1",
  "aclScope" : "ACCESS",
  "aclList" : [ "READ", "WRITE", "READ_ACL", "WRITE_ACL" ]
} ]' does not match '"type" : "GROUP",
.*"name" : "superuser1*",
.*"aclScope" : "ACCESS",
.*"aclList" : . "READ", "WRITE", "READ_ACL", "WRITE_ACL"'

The test sets user ACL, but checks group ACL. I think this passed previously due to a bug that was fixed by HDDS-1917.

https://issues.apache.org/jira/browse/HDDS-1966

How was this patch tested?

Ran ozonesecure acceptance test, verified that key ACL checks were passing.

@adoroszlai
Copy link
Contributor Author

/label ozone

@elek elek added the ozone label Aug 14, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 69 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 605 trunk passed
+1 compile 370 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 1836 branch has no errors when building and testing our client artifacts.
+1 javadoc 168 trunk passed
_ Patch Compile Tests _
+1 mvninstall 553 the patch passed
+1 compile 374 the patch passed
+1 javac 374 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 744 patch has no errors when building and testing our client artifacts.
+1 javadoc 178 the patch passed
_ Other Tests _
+1 unit 362 hadoop-hdds in the patch passed.
-1 unit 656 hadoop-ozone in the patch failed.
+1 asflicense 37 The patch does not generate ASF License warnings.
5172
Reason Tests
Failed junit tests hadoop.ozone.s3.TestOzoneClientProducer
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1295/1/artifact/out/Dockerfile
GITHUB PR #1295
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient
uname Linux f6466b75cfe5 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 83e452e
Default Java 1.8.0_222
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1295/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1295/1/testReport/
Max. process+thread count 1263 (vs. ulimit of 5500)
modules C: hadoop-ozone/dist U: hadoop-ozone/dist
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1295/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@adoroszlai
Copy link
Contributor Author

Thanks @anuengineer and @nandakumar131 for commiting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants